Skip to content

Update Date/Time Selector #793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Update Date/Time Selector #793

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
75fc672
Update d/t selector styling and types
amy-corson-ibigroup Nov 4, 2024
ea03d07
Fix d/t selector story styling
amy-corson-ibigroup Nov 4, 2024
d2855f5
Force "depart" on time change, remove unneeded containers and styling
amy-corson-ibigroup Nov 4, 2024
7fc56a4
feat(tip-form): update date time selector
amy-corson-ibigroup Nov 21, 2024
352d394
remove isSelected
amy-corson-ibigroup Jan 27, 2025
1e24618
change default to grey
amy-corson-ibigroup Feb 4, 2025
44a98bd
Update packages/trip-form/src/types.ts
amy-corson-ibigroup Feb 20, 2025
f92704b
Update packages/trip-form/src/styled.ts
amy-corson-ibigroup Feb 20, 2025
97e88b0
sort and cleanup css
amy-corson-ibigroup Feb 20, 2025
1b8539c
Merge branch 'update-dt-selector' of https://github.com/ibi-group/otp…
amy-corson-ibigroup Feb 20, 2025
8c96fc8
Update snapshots
amy-corson-ibigroup Feb 20, 2025
43e2d1c
fix lint issue
amy-corson-ibigroup Feb 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/trip-form/src/DateTimeSelector/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,8 @@ function isInputTypeSupported(type: string): boolean {

const supportsDateTimeInputs = isInputTypeSupported("date") && isInputTypeSupported("time");

const buttonStyle = { backgroundColor: S.baseColor() || grey[700], border: "0px", borderRadius: "3px 0px 0px 3px", color: "white", height: "45px" }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Break up this long line


/**
* Reference date for parsing.
*/
Expand Down Expand Up @@ -216,7 +218,7 @@ export default function DateTimeSelector({
style={style}
baseColor={baseColor}
>
<Dropdown alignMenuLeft id="date-time-depart-arrive" text={departureOptions.find(opt => opt.type === departArrive).text} buttonStyle={{ backgroundColor: S.baseColor() || grey[700], borderRadius: "3px 0px 0px 3px", color: "white", height: "45px", border: "0px" }}>
<Dropdown alignMenuLeft id="date-time-depart-arrive" text={departureOptions.find(opt => opt.type === departArrive).text} buttonStyle={buttonStyle}>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Breakup this long line.

{departureOptions.map(opt => (
<button
aria-pressed={opt.type === departArrive}
Expand Down
2 changes: 1 addition & 1 deletion ...s/trip-form/src/MetroModeSelector/__snapshots__/AdvancedModeSettingsButton.story.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ exports[`Trip Form Components/Advanced Mode Settings Buttons AdvancedModeSetting
</label>
</div>
</div>
<div class="styled__DropdownSelector-sc-122ziys-17 kiQdDP">
<div class="styled__DropdownSelector-sc-122ziys-16 jBvmxW">
<div>
<label for="id-query-param-busColor"
class="styled__SettingLabel-sc-122ziys-2 hlSjLd"
Expand Down
Loading