Remove stop_id from display logic in favor of stop_code
#895
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-heppner-ibigroup
requested changes
Dec 22, 2025
Contributor
daniel-heppner-ibigroup
left a comment
daniel-heppner-ibigroup
left a comment
There was a problem hiding this comment.
Going to have to check out what's going on with typescript here and why it's not giving an error for this
| } | ||
| return stopCode || stopId?.split(":")[1] || stopId; | ||
| return stopCode || null; | ||
| } |
Contributor
There was a problem hiding this comment.
I'm surprised you're not getting a type error from this. Null is not a valid return type from this function. I suggest using undefined instead, add it to the return type, and instead of using let stopCode just refactor the function to return from inside the if else blocks.
Also noting that using || is not safe with strings because "" is considered falsey and || checks for falsey. Use ?? instead which is actually checking for null or undefined only.
| */ | ||
| export function getDisplayedStopId(placeOrStop: Place | Stop): string { | ||
| let stopId; | ||
| export function getDisplayedStopCode(placeOrStop: Place | Stop): string { |
Contributor
There was a problem hiding this comment.
renaming this function is a breaking change!
daniel-heppner-ibigroup
assigned
josh-willis-arcadis and unassigned
daniel-heppner-ibigroup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored a
core-utilfunction to only returnstop_codeif found for display in the UI. UI language has been updated to reflect these changes in the packagesitinerary-bodyandprintable-itinerary.