Update hmtx.js to read leftSideBearing array when numGlyphs > numMetrics #559
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sigurdle does this break any tests. Also can you write a test for this? |
Connum
added
Spec
|
@sigurdle any updates on writing tests for this? |
|
Pinging @sigurdle |
|
@sigurdle any news? |
|
Hi, I apologize, I am not well versed in the the "correct" way to add new code to github repository with tests etc. I also see above that there are some failings happening with eslint in the code I added. Is that just spacing issues? It would be best if someone looks at that . |
|
I just fixed the linting issues and rebased on the current master. How did you spot this issue before you opened #546? Didn't you havve a font with which you encountered issues? |
|
I spotted it by accident as I was reading the spec |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
npm run testand all tests passed green (including code styling checks).