-
Notifications
You must be signed in to change notification settings - Fork 501
Parse cmap table format 14 and handle Unicode Variation Sequences (UVSes) #581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I'll review it after work today |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've written a few comments/questions, once those are discussed I will do an approving review. They aren't necessarily show-stoppers so I'm not going to request changes, but we should discuss them.
5e5e241
to
a5bc2a7
Compare
rebased on current master |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Description
This PR implements parsing of cmap table format 14 and applying Unicode Variation Sequences (UVSes) during rendering.
Writing is not yet implemented and will be added later in a separate PR.
Motivation and Context
This will get rid of the
.null
glyph being displayed for variation selectors in text and swap the base character to the desired variation if supported by the font. We'll pass tests CMAP-1 and CMAP-2 of the Unicode test report tool as a result.How Has This Been Tested?
Added tests, tested with fonts, ran the Unicode test report (with #568 implemented in a test branch).
Screenshots (if appropriate):
Types of changes
Checklist:
npm run test
and all tests passed green (including code styling checks).