handle CMAP format 0 for platform 1, encoding 0 (legacy Macintosh encoding) #634
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for Macintosh encoding in the form of CMAP table format 0 with platformId 1 and encodingId 0.
Motivation and Context
Although deprecated, older fonts may still use this encoding format.
The CMAP-3 test case of the unicode test tool failed for Opentype.js and didn't show any glyphs at all. The tests are still not marked as conformant after this PR due to small decimal rounding differences, but that is a separate issue and visually the glyphs render OK.
How Has This Been Tested?
Added tests, ran the unicode test tool with the local dev branch and compared the outlines.
Screenshots (if appropriate):
unicode test tool test case CMAP-3 before:
unicode test tool test case CMAP-3 after:
Types of changes
Checklist:
npm run test
and all tests passed green (including code styling checks).