-
Notifications
You must be signed in to change notification settings - Fork 572
UCP: SGL datatype implementation #11344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
44 commits
Select commit
Hold shift + click to select a range
066ab45
UCP: SGL datatype implementation
michal-shalev c5afa20
UCT: Remove 2x uct_ep_put_sgl_zcopy
michal-shalev 31339b6
UCP/UCT: Update copyrights
michal-shalev 2a98569
UCP: Fix copyrights for new files
michal-shalev 731a918
UCP: Check return status of uct_iface_query_v2
michal-shalev 3455df1
UCT: Fix uct_iface_attr_v2_t layout and align v2 iface cap docs
michal-shalev 772f2b1
GTEST/UCP: Drop v2 lane caps query + add negative test put_zero_count
michal-shalev 57ddf98
UCP/RMA: initialize next_iter before iface query to fix -Wmaybe-unini…
michal-shalev 4c3114a
GTEST/UCP: Remove copyrights fix in files that didn't change
michal-shalev 24b9d43
GTEST/UCP: Add mixed mem types test
michal-shalev 7598a51
UCP: Add UCP_REQUEST_CHECK_PARAM_UNSUPPORTED_REMOTE
michal-shalev 6b762c2
UCP: Remove copyrights years fix for non-NVIDIA
michal-shalev d19b8fb
UCP/DT: Remove ucp_datatype_iter_sgl_allocate_memh
michal-shalev 6ce20ad
UCP/PROTO: cache max_put_sgl_zcopy_count
michal-shalev 979021d
UCP/RMA/PUT: simplify put_sgl_offload_send_func
michal-shalev ef2a72e
UCP/DT: Rename ucp_datatype_sgl_iter_init to ucp_datatype_iter_sgl_init
michal-shalev fd3c63f
UCP/CORE: Unite UCP_REQUEST_CHECK_PARAM with UCP_REQUEST_CHECK_PARAM_…
michal-shalev 16d0a04
UCP: Remove copyrights fix in files that didn't change
michal-shalev beef5cb
UCP/API: document SGL same-memtype requirement for ucp_dt_local_sgl_t
michal-shalev ac516f1
UCP/DT: Extract shared ucp_dt_mem_type_check_elem helper for IOV/SGL …
michal-shalev 3f3af4a
UCP/DT: rename mem_type check helpers to mem_info for accuracy
michal-shalev d149ff3
UCP/DT: validate per-element memhs in SGL user-memh path
michal-shalev f1c4377
UCP/DT: handle count == 0 in SGL iterator init
michal-shalev 43721dc
UCP/RMA: Reject SGL put when proto path is disabled
michal-shalev 23a1dcb
Merge branch 'master' into HEAD
michal-shalev e9b8c4e
UCP/REQUEST: Reject SGL datatype on non-put APIs
michal-shalev 24e72d5
UCP: Asserts for Coverity
michal-shalev 2606812
UCP/TAG: Suppress Coverity false positive on legacy recv_nb user_data
michal-shalev 7f3fa91
UCP/DT: Drop sgl.memhs_owned, infer ownership from memhs[0]
michal-shalev ee638da
TEST/UCP: Update ucp_request_t expected size to 280
michal-shalev 628ff88
UCP/PROTO/RECONFIG: Abort request when no wireup proxy lane is left
michal-shalev e358808
UCP/DT: Validate that all SGL rkeys share the same rkey configuration
michal-shalev daf743c
UCP/PROTO: Declare per-protocol supported datatype-class mask
michal-shalev 7e4ccd0
UCP: Fix copyrights
michal-shalev 6934aa2
UCP/PROTO: Fix Coverity overrun warning in proto select loop
michal-shalev f01b9d6
UCP/REQUEST: Split UCP_REQUEST_CHECK_PARAM into _COMMON and _NO_REMOT…
michal-shalev 880cdc0
UCP/CORE: Skip param validation for ops with no datatype/remote seman…
michal-shalev 684a494
UCP/DT: Pass buffers/lengths directly to ucp_dt_sgl_check_same_mem_info
michal-shalev d870e0a
Merge branch 'master' into ucp-sgl-put-impl
michal-shalev 3b1da4d
GTEST/UCP: Skip SGL put tests when v2 put_sgl_zcopy cap is missing
michal-shalev ef6950a
Merge branch 'master' into ucp-sgl-put-impl
michal-shalev 12eefc5
UCP/RKEY: Remove extra spaces
michal-shalev 4916e62
UCP/RMA: Convert SGL put param validation to macro and check remote l…
michal-shalev a360442
UCP/GTEST: Add negative test for missing remote SGL lengths in put
michal-shalev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would
UCS_ERR_INVALID_PARAMbe always returned with mixed memory types, or only whenENABLE_PARAMS_CHECKis on?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only when ENABLE_PARAMS_CHECK is on, matching IOV datatype path.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure what is the standards for the docs, but is it okay that it doesn't mention the dependence on
ENABLE_PARAMS_CHECK? (The text implies it will always happen)