Fix #127: TypeError when mapping_quality is None#141
Merged
Conversation
Guard on mapping_quality is None first, regardless of min_mapping_quality. When min_mapping_quality > 0, reads with None MAPQ are skipped (as before). When min_mapping_quality == 0, None MAPQ is treated as 0 so the comparison does not raise TypeError. Fixes #127
|
coverage: 93.067% (+0.1%) from 92.969% — fix-127-mapq-none-typeerror-v2 into master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mapping_quality is Nonefirst, before any numeric comparison.min_mapping_quality == 0, treatNoneMAPQ as0instead of crashing.Fixes #127
Test plan
./test.shpasses (154 tests)./lint.shpasses