Skip to content

[codex] Restore allele-count CLI output#169

Merged
iskandr merged 1 commit into
masterfrom
codex/fix-allele-counts-cli-output
Apr 23, 2026
Merged

[codex] Restore allele-count CLI output#169
iskandr merged 1 commit into
masterfrom
codex/fix-allele-counts-cli-output

Conversation

@iskandr

@iskandr iskandr commented Apr 23, 2026

Copy link
Copy Markdown
Contributor

Summary

  • route isovar-allele-counts through the dedicated counts dataframe helper
  • restore fragment-count columns and the num_*_reads schema promised by the docs
  • fix the CLI output description so it matches the command behavior
  • add regression coverage for both fragment deduplication and the CLI wiring

Root Cause

isovar-allele-counts was wired to the generic read-evidence dataframe path instead of the dedicated counts helper that already existed in dataframe_helpers.py. That generic path collapses the read lists to lengths but leaves the old ref_reads / alt_reads / other_reads column names and drops fragment counts entirely, so the CLI no longer matched its documented contract.

Validation

  • ./lint.sh
  • ./test.sh

Closes #164.

@iskandr iskandr marked this pull request as ready for review April 23, 2026 15:22
@coveralls

Copy link
Copy Markdown

Coverage Status

coverage: 93.426% (-0.09%) from 93.511% — codex/fix-allele-counts-cli-output into master

@coveralls

Copy link
Copy Markdown

Coverage Status

coverage: 93.426% (-0.09%) from 93.511% — codex/fix-allele-counts-cli-output into master

@iskandr iskandr merged commit 7c23561 into master Apr 23, 2026
6 checks passed
@iskandr iskandr deleted the codex/fix-allele-counts-cli-output branch April 23, 2026 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

isovar-allele-counts is wired to the wrong DataFrame helper

2 participants