[codex] Fix boundary read evidence counts#172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes read-evidence undercounting at locus boundaries and adds regression coverage around the affected cases.
What changed
LocusReadregressions for insertion support at read boundariesisovarto1.4.22Why
ReadCollector.locus_read_from_pysam_aligned_segment(...)handled insertions by requiring mapped flanks on both sides of the insertion site. That drops reads whose inserted bases occur at the start or end of the aligned query even though those reads still contain valid allele evidence. Those drops then propagate into allele-read exports and read counts.The older exon-boundary/read-boundary bugs were also only weakly pinned down by tests. This PR makes those cases explicit at the unit level.
Impact
isovar-allele-readsemits one more real-data row in the bundled fixture set because the missing boundary read is now recoveredValidation
./lint.sh./test.shCloses #49
Closes #23
Closes #24
Closes #55
Refs #14