Fix #280: distance_to_locus supports ignore_strand for cross-strand distances#336
Merged
Merged
Conversation
…istances Previously distance_to_locus always returned inf for loci on opposite strands of the same contig. The default behavior is preserved; passing ignore_strand=True now yields a strand-invariant distance. Bump version to 2.6.10.
|
coverage: 83.652% (+0.01%) from 83.642% — fix-280-distance-to-locus-ignore-strand into main |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ignore_strand=Falsekeyword toLocus.distance_to_locusso callers can opt into a strand-invariant distance instead of gettinginfwhen two loci are on opposite strands of the same contig.inffor different contigs, andinffor opposite strands unless the caller opts in.Closes #280.
Test plan
pytest tests/test_locus.py./lint.sh