Windows support (incl. AppVeyor CI builds) #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We add a `config.w32` which relies on the usual dependency layout. We also do the following replacements to be able to build on Windows: * `ulong` => `unsigned long` * `strndup()` => `zend_strndup()`
We add basic AppVeyor CI support for building the extension, and for packing a PECL like Zip archive with the binaries.
Author
|
The Travis CI failure is due to PHP 5.5 not being available. It seems to make sense to update .travis.yml to use more recent PHP versions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There seems to be interest in being able to use php-postal on Windows (#16); these patches add basic Windows support, and the AppVeyor CI integration shows how that can be accomplished (plus it creates PECL like binary packages as artifacts).
I think a lot could be improved here; particularly, the hard coded URL of the libpostal binary package, which points to the AppVeyor artifacts of the currently latest commit, is obviously suboptimal.
Furthermore, it would be nice to know how to get the libpostal data for users (and also for AppVeyor CI to be able to run the test suite). @c33s's solution worked for me (thanks!), but I'd prefer a Windows only solution.