Skip to content

refresh src in build #3979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dtrawins wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −0
Open

refresh src in build #3979

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions windows_install_build_dependencies.bat
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,6 +248,7 @@ git checkout %OV_SOURCE_BRANCH%
if !errorlevel! neq 0 exit /b !errorlevel!
git submodule update --init --recursive
if !errorlevel! neq 0 exit /b !errorlevel!
git pull --recurse-submodules
Copy link

Copilot AI Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OV_SOURCE_BRANCH defaults to a specific commit SHA (detached HEAD). Running git pull in detached HEAD will fail ("You are not currently on a branch") and is also ignored here (no errorlevel check). Consider removing this pull, or only pulling when %OV_SOURCE_BRANCH% is an actual branch name; for pinned SHAs, git fetch + git checkout is sufficient and keeps builds reproducible.

Suggested change
git pull --recurse-submodules
for /f "delims=" %%i in ('git symbolic-ref --short -q HEAD 2^>nul') do set "GIT_CURRENT_BRANCH=%%i"
if defined GIT_CURRENT_BRANCH (
git pull --recurse-submodules
)

Copilot uses AI. Check for mistakes.
IF /I NOT EXIST build (
mkdir build
)
Expand All @@ -271,6 +272,7 @@ cd %BAZEL_SHORT_PATH%\openvino_tokenizers_src
git fetch origin
git checkout %TOKENIZER_SOURCE_BRANCH%
if !errorlevel! neq 0 exit /b !errorlevel!
git pull --recurse-submodules
Copy link

Copilot AI Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TOKENIZER_SOURCE_BRANCH defaults to a commit SHA, so this git pull will fail in detached HEAD and its failure is currently ignored (no errorlevel check). If the intent is to stay pinned, drop the pull; if the intent is to track a branch, gate the pull on being on a branch and ensure failure stops the script.

Suggested change
git pull --recurse-submodules
for /f "delims=" %%h in ('git rev-parse --abbrev-ref HEAD') do set "GIT_BRANCH=%%h"
IF /I NOT "!GIT_BRANCH!"=="HEAD" (
git pull --recurse-submodules
if !errorlevel! neq 0 exit /b !errorlevel!
)

Copilot uses AI. Check for mistakes.
IF /I NOT EXIST build (
mkdir build
)
Expand All @@ -292,6 +294,7 @@ cd %BAZEL_SHORT_PATH%\openvino_genai_src
git fetch origin
git checkout %GENAI_SOURCE_BRANCH%
if !errorlevel! neq 0 exit /b !errorlevel!
git pull --recurse-submodules
Copy link

Copilot AI Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GENAI_SOURCE_BRANCH defaults to a commit SHA, which puts the repo in detached HEAD; git pull will fail in that state and the script does not check errorlevel afterwards. Recommend removing this pull (fetch+checkout already refreshes) or performing a deterministic update (e.g., fetch then reset/checkout the requested ref) with proper error handling.

Suggested change
git pull --recurse-submodules

Copilot uses AI. Check for mistakes.
IF /I NOT EXIST build (
mkdir build
)
Expand Down