Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aanuf/data free awq #3315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Aanuf/data free awq #3315
Changes from 20 commits
488cacc
ee64877
f22e411
51b4d7b
f66cd1e
7ce5a53
f74d156
5288c79
1becf15
047d7d9
c0c7e57
b74dea1
26a9a77
25fcc2c
f6f4693
19a64ac
bf215d5
566ebe7
70e47c8
6b3310b
c13437f
519727f
10920a2
35f6a64
83c7867
a17b896
516fec7
48e7f1c
57c3e4a
cd9e4c1
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please redefine
self._data_aware_compression
as following:Then we can rollback this if statement to the original form.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have to change my original suggestion here 🙂 After the recent changes (
is_data_aware
->prefer_data_aware
) I think it actually makes more sense to defineBecause otherwise it can happen that
self._data_aware_compression
is True, but data-aware won't actually be applied. This is in caseself._awq
is True and dataset is not provided.And then we can do: