Skip to content

Move function hook mode from experimental to torch #3437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 21, 2025
Merged

Move function hook mode from experimental to torch #3437

merged 5 commits into from
Apr 21, 2025

Conversation

AlexanderDokuchaev
Copy link
Collaborator

@AlexanderDokuchaev AlexanderDokuchaev commented Apr 16, 2025 •
edited
Loading

Changes

Move function hook mode from experimental to torch directory
Rename is_torch_tracing_by_torch_function_mode to is_torch_tracing_by_patching

Tests

https://github.com/openvinotoolkit/nncf/actions/runs/14492127237

@github-actions github-actions bot added NNCF PT Pull requests that updates NNCF PyTorch NNCF Common Pull request that updates NNCF Common experimental NNCF PTQ Pull requests that updates NNCF PTQ labels Apr 16, 2025
@AlexanderDokuchaev AlexanderDokuchaev marked this pull request as ready for review April 16, 2025 12:38
@AlexanderDokuchaev AlexanderDokuchaev requested a review from a team as a code owner April 16, 2025 12:38
@alexsu52 alexsu52 requested a review from daniil-lyakhov April 17, 2025 14:03
alexsu52
alexsu52 reviewed Apr 20, 2025
View reviewed changes
Copy link
Contributor

@alexsu52 alexsu52 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please, address to my minor comment.

@alexsu52 alexsu52 merged commit 6a45da5 into openvinotoolkit:develop Apr 21, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexsu52 alexsu52 alexsu52 approved these changes

@daniil-lyakhov daniil-lyakhov Awaiting requested review from daniil-lyakhov

Assignees

@alexsu52 alexsu52

Labels
experimental NNCF Common Pull request that updates NNCF Common NNCF PT Pull requests that updates NNCF PyTorch NNCF PTQ Pull requests that updates NNCF PTQ
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexanderDokuchaev @alexsu52