-
Notifications
You must be signed in to change notification settings - Fork 256
Tensor stats migration #3440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Tensor stats migration #3440
Conversation
…rimental implementation
This PR is related to the issue #3041 and the changes implemented are:
Current status:
I noticed the experimental implementation is missing:
These components are widely used throughout the codebase (30+ files). Could you please advice if I should implement these missing components as part of the experimental implementation, or is there a different approach you would recommend? |
Hi @alexsu52 Sir, could you please have a look at the previous comment and advice me on how I should proceed? |
@@ -28,6 +27,8 @@ | |||
from nncf.tensor import Tensor | |||
|
|||
InplaceInsertionFNType = TypeVar("InplaceInsertionFNType") | |||
# AggregationAxes serves the same purpose as ReductionAxes in the old implementation | |||
# but is defined here to break circular dependencies | |||
AggregationAxes = Tuple[int, ...] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this help with cyclical dependencies?
AggregationAxes = Tuple[int, ...] | |
AggregationAxes = Tuple[int, ...] | |
ReductionAxes = Tuple[int, ...] |
|
Changes
Reason for changes
Related tickets
Tests