Register SingleConfigQuantizationPoint in CommonStatefulClassesRegistry#3978
Open
abhayuvi wants to merge 1 commit intoopenvinotoolkit:developfrom
Open
Register SingleConfigQuantizationPoint in CommonStatefulClassesRegistry#3978abhayuvi wants to merge 1 commit intoopenvinotoolkit:developfrom
abhayuvi wants to merge 1 commit intoopenvinotoolkit:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
SingleConfigQuantizationPointis now decorated with@CommonStatefulClassesRegistry.register().SingleConfigQuantizerSetup.from_state()is updated to load
SingleConfigQuantizationPointvia the registry instead of callingit directly. A new test file
tests/common/quantization/test_quantizer_setup.pyisadded to cover the registry lookup and get_state/from_state round-trips.
Reason for changes
SingleConfigQuantizationPointhad afrom_state()method but was missing its@CommonStatefulClassesRegistry.register()decoration, unlike all other statefulclasses in the same file (
WeightQuantizationInsertionPoint,ActivationQuantizationInsertionPoint,TargetPoint). This madeSingleConfigQuantizerSetup.from_state()bypass the registry and call the classdirectly, inconsistent with the established pattern.
Related tickets
#3574
Tests
tests/common/quantization/test_quantizer_setup.pySingleConfigQuantizationPoint, get_state/from_stateround-trip for both weight and activation insertion points, and unified scale group
preservation across a
SingleConfigQuantizerSetupround-triptests/common/quantization/continue to pass