Minor: redundant get_raw_statistic_collector backend methods are removed#3979
Open
daniil-lyakhov wants to merge 1 commit intoopenvinotoolkit:developfrom
Open
Minor: redundant get_raw_statistic_collector backend methods are removed#3979daniil-lyakhov wants to merge 1 commit intoopenvinotoolkit:developfrom
daniil-lyakhov wants to merge 1 commit intoopenvinotoolkit:developfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes redundant backend-specific raw_statistic_collector methods and switches call sites to use the shared get_raw_stat_collector builder directly, simplifying backend interfaces for bias correction and layerwise engines.
Changes:
- Removed
raw_statistic_collectorabstract methods from bias-correction and layerwise backend base classes. - Deleted corresponding backend implementations (ONNX/OpenVINO/Torch FX bias correction backends; OpenVINO layerwise backend).
- Updated bias-correction and layerwise engine code (and a related test) to use
nncf.common.tensor_statistics.builders.get_raw_stat_collector.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/common/test_statistics_aggregator.py | Updates the RAW collector test path to use get_raw_stat_collector directly. |
| src/nncf/quantization/algorithms/layerwise/openvino_backend.py | Removes redundant raw-stat collector method and now-unneeded imports. |
| src/nncf/quantization/algorithms/layerwise/engine.py | Uses get_raw_stat_collector directly instead of backend method. |
| src/nncf/quantization/algorithms/layerwise/backend.py | Drops the raw-stat collector abstract method from the backend interface. |
| src/nncf/quantization/algorithms/bias_correction/torch_fx_backend.py | Removes redundant raw-stat collector method and its import. |
| src/nncf/quantization/algorithms/bias_correction/openvino_backend.py | Removes redundant raw-stat collector method and its import. |
| src/nncf/quantization/algorithms/bias_correction/onnx_backend.py | Removes redundant raw-stat collector method and its import. |
| src/nncf/quantization/algorithms/bias_correction/backend.py | Drops the raw-stat collector abstract method from the backend interface. |
| src/nncf/quantization/algorithms/bias_correction/algorithm.py | Uses get_raw_stat_collector directly instead of backend method. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made by Claude Opus 4.6Changes
Remove the redundant raw_statistic_collector abstract method from
algorithm backends