Skip to content

Minor: redundant get_raw_statistic_collector backend methods are removed#3979

Open
daniil-lyakhov wants to merge 1 commit intoopenvinotoolkit:developfrom
daniil-lyakhov:dl/redundant_backend
Open

Minor: redundant get_raw_statistic_collector backend methods are removed#3979
daniil-lyakhov wants to merge 1 commit intoopenvinotoolkit:developfrom
daniil-lyakhov:dl/redundant_backend

Conversation

@daniil-lyakhov
Copy link
Collaborator

Made by Claude Opus 4.6

Changes

Remove the redundant raw_statistic_collector abstract method from
algorithm backends

@daniil-lyakhov daniil-lyakhov requested a review from a team as a code owner March 12, 2026 14:06
Copilot AI review requested due to automatic review settings March 12, 2026 14:06
@github-actions github-actions bot added the NNCF Common Pull request that updates NNCF Common label Mar 12, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes redundant backend-specific raw_statistic_collector methods and switches call sites to use the shared get_raw_stat_collector builder directly, simplifying backend interfaces for bias correction and layerwise engines.

Changes:

  • Removed raw_statistic_collector abstract methods from bias-correction and layerwise backend base classes.
  • Deleted corresponding backend implementations (ONNX/OpenVINO/Torch FX bias correction backends; OpenVINO layerwise backend).
  • Updated bias-correction and layerwise engine code (and a related test) to use nncf.common.tensor_statistics.builders.get_raw_stat_collector.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tests/common/test_statistics_aggregator.py Updates the RAW collector test path to use get_raw_stat_collector directly.
src/nncf/quantization/algorithms/layerwise/openvino_backend.py Removes redundant raw-stat collector method and now-unneeded imports.
src/nncf/quantization/algorithms/layerwise/engine.py Uses get_raw_stat_collector directly instead of backend method.
src/nncf/quantization/algorithms/layerwise/backend.py Drops the raw-stat collector abstract method from the backend interface.
src/nncf/quantization/algorithms/bias_correction/torch_fx_backend.py Removes redundant raw-stat collector method and its import.
src/nncf/quantization/algorithms/bias_correction/openvino_backend.py Removes redundant raw-stat collector method and its import.
src/nncf/quantization/algorithms/bias_correction/onnx_backend.py Removes redundant raw-stat collector method and its import.
src/nncf/quantization/algorithms/bias_correction/backend.py Drops the raw-stat collector abstract method from the backend interface.
src/nncf/quantization/algorithms/bias_correction/algorithm.py Uses get_raw_stat_collector directly instead of backend method.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

NNCF Common Pull request that updates NNCF Common

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants