Skip to content

Conversation

@AlexanderKalistratov
Copy link
Contributor

  • Remove unnecessary assert
  • Add test

@github-actions github-actions bot added category: visual language Visual language pipeline category: GGUF GGUF file reader labels Dec 12, 2025
@Wovchena Wovchena requested a review from Copilot December 12, 2025 08:53
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enables support for multiple images in VLM (Vision Language Model) pipelines when using NPU devices by removing an overly restrictive assertion that limited batch sizes to 1.

Key Changes:

  • Removed the assertion that restricted NPU VLM pipelines to a single image/video
  • Added a new test to verify multiple image support on NPU
  • Simplified an existing test by removing unnecessary loop over multiple images

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/cpp/src/visual_language/pipeline.cpp Removed assertion limiting NPU to single image/video processing
tests/python_tests/test_vlm_pipeline.py Added test for multiple images, simplified existing test, and added missing platform skip decorator

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +893 to +895
ov_pipe.generate(
PROMPTS[0], images=[cat_tensor], generation_config=generation_config
)
Copy link

Copilot AI Dec 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The indentation of the ov_pipe.generate() call has changed from being inside a loop to standalone, but the indentation level appears inconsistent. The function call should be indented 4 spaces from the function definition, matching the style of other statements at the same level.

Copilot uses AI. Check for mistakes.
@Wovchena Wovchena requested a review from sgonorov December 12, 2025 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category: GGUF GGUF file reader category: visual language Visual language pipeline

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants