Skip to content

Conversation

@olpipi
Copy link
Collaborator

@olpipi olpipi commented Dec 17, 2025

No description provided.

Copilot AI review requested due to automatic review settings December 17, 2025 09:51
@github-actions github-actions bot added category: WWB PR changes WWB category: continuous batching Continuous batching category: GGUF GGUF file reader labels Dec 17, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds comprehensive logging infrastructure to test files for CI debugging purposes. The changes introduce timestamped logging utilities (_ts(), _log(), _stage()) and detailed timing measurements to help diagnose test execution issues in the CI environment.

Key changes:

  • Added standardized logging helper functions across all test files with timestamps in UTC
  • Instrumented test execution with timing measurements for model downloads, conversions, and generation steps
  • Added checks for offline mode environment variables to skip tests when network access is unavailable

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tools/who_what_benchmark/tests/test_cli_vlm.py Added logging utilities, timing measurements for optimum-cli exports, and executable checks
tools/who_what_benchmark/tests/test_cli_text.py Added logging utilities with timing for model downloads and conversions during test setup
tools/who_what_benchmark/tests/test_cli_reranking.py Added logging utilities, executable checks, and timing for model exports
tools/who_what_benchmark/tests/test_cli_image.py Added logging utilities, context manager for timing stages, and executable validation
tools/who_what_benchmark/tests/test_cli_embeddings.py Added logging utilities with timing measurements for optimum-cli exports
tests/python_tests/test_kv_cache_eviction/test_kv_cache_eviction_2.py Added logging utilities, offline mode checks, and timing for dataset loading and generation
tests/python_tests/test_kv_cache_eviction/test_kv_cache_eviction_1.py Added logging utilities, offline mode checks, and timing for all major test stages

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant