Skip to content

[CORE] Squeeze v15 reverse infer #27526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 35 commits into
base: master
Choose a base branch
from
Open

[CORE] Squeeze v15 reverse infer #27526

wants to merge 35 commits into from
+279 −104

Conversation

barnasm1
Copy link
Contributor

@barnasm1 barnasm1 commented Nov 12, 2024 •
edited
Loading

Details:

  • Add reverse shape inference transformation for squeeze v15
  • Refactor squeeze shape inference

Tickets:

@barnasm1 barnasm1 added category: Core OpenVINO Core (aka ngraph) no_stale Do not mark as stale labels Nov 12, 2024
@barnasm1 barnasm1 self-assigned this Nov 12, 2024
@barnasm1 barnasm1 requested review from a team as code owners November 12, 2024 16:31
@barnasm1 barnasm1 added the WIP work in progress label Nov 12, 2024
@github-actions github-actions bot added category: TEMPLATE OpenVINO Template plugin category: CPP API OpenVINO CPP API bindings labels Nov 12, 2024
@barnasm1 barnasm1 requested a review from a team as a code owner November 13, 2024 07:58
@barnasm1 barnasm1 requested a review from a team as a code owner November 13, 2024 08:45
@barnasm1 barnasm1 requested review from itikhono and removed request for a team November 13, 2024 08:45
@github-actions github-actions bot added the category: transformations OpenVINO Runtime library - Transformations label Nov 13, 2024
@github-actions github-actions bot removed category: TEMPLATE OpenVINO Template plugin category: CPP API OpenVINO CPP API bindings labels Nov 13, 2024
@github-actions github-actions bot added the category: CPP API OpenVINO CPP API bindings label Nov 14, 2024
@github-actions github-actions bot removed the category: CPP API OpenVINO CPP API bindings label Nov 15, 2024
@mlukasze mlukasze requested a review from t-jankowski November 18, 2024 06:37
@barnasm1 barnasm1 requested a review from a team as a code owner November 25, 2024 09:02
@barnasm1 barnasm1 requested review from ilya-lavrenov and removed request for a team November 25, 2024 09:02
@github-actions github-actions bot added category: CPP API OpenVINO CPP API bindings no-match-files labels Nov 25, 2024
praasz
praasz requested changes Nov 26, 2024
View reviewed changes
src/core/src/op/squeeze.cpp
@@ -95,6 +95,7 @@ void Squeeze::validate_and_infer_types() {
const auto output_shapes = shape_infer(this, input_shapes);

set_output_type(0, get_input_element_type(0), output_shapes[0]);
get_rt_info().erase(output_rt_info_name);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it should be part of reverse shape infer transformation, as clean-up process when completed?
Running function validate_and_infer_types twice will may give different output shapes.

@barnasm1 barnasm1 added do_not_merge and removed WIP work in progress labels Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@praasz praasz praasz requested changes

@itikhono itikhono Awaiting requested review from itikhono itikhono is a code owner automatically assigned from openvinotoolkit/openvino-ie-transformations-maintainers

@t-jankowski t-jankowski Awaiting requested review from t-jankowski

@ilya-lavrenov ilya-lavrenov Awaiting requested review from ilya-lavrenov ilya-lavrenov was automatically assigned from openvinotoolkit/openvino-maintainers

Requested changes must be addressed to merge this pull request.

Assignees

@barnasm1 barnasm1

Labels
category: Core OpenVINO Core (aka ngraph) category: CPP API OpenVINO CPP API bindings category: transformations OpenVINO Runtime library - Transformations do_not_merge no_stale Do not mark as stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@barnasm1 @t-jankowski @praasz