Make headers self-contained #28942
Make headers self-contained #28942
Conversation
|
build_jenkins |
| @@ -4,7 +4,13 @@ | |||
|
|
|||
| #pragma once | |||
|
|
|||
| #include <cstddef> | |||
|
|
|||
| #ifdef OPENVINO_CPP_17_VER | |||
There was a problem hiding this comment.
This is not required as CPP17 is default standard
There was a problem hiding this comment.
Does it mean that we also want to remove the check in L16?
There was a problem hiding this comment.
As we moved to CPP17 as default standard, this file could be even removed, and use std::optional instead ov::optional or just leave alias.
If file not remove could you update to copyright note to:
// Copyright (C) 2018-2025 Intel Corporation
// SPDX-License-Identifier: Apache-2.0
//
There was a problem hiding this comment.
I'll mark this conversation as resolved and rebase this PR once that PR got merged.
github-actions
bot
added
category: inference
### Description: As CPP17 is the default standard of OpenVINO, there is no need to use the self-implemented optional struct. Note: discussed in #28942. ### Related PRs: - #28942 Co-authored-by: Michal Lukaszewski <[email protected]>
|
#28949 has been merged |
oToToT
force-pushed
the
ov-build-fix
branch
2 times, most recently
from
164b6f4 to
ffec4b9
Compare
It seems like most of the headers in OpenVINO are self-contained, but some are not. It will be nice to make every headers self-contained. This commit fixes some headers found not to be self-contained, but this is not a complete list. Just some headers found during my local compilation.
|
hey @oToToT, will you find a time to finish this PR? could be kinds useful for us :) |
|
Apologize that I slow down the process because it's a bit larger than I expected earlier. However, I'm still interested working on this. And I do have some progress more than this PR on my local branch. |
|
That's great! |
It seems like most of the headers in OpenVINO are self-contained, but some are not. It will be nice to make every headers self-contained. This commit fixes some headers found not to be self-contained, but this is not a complete list. Just some headers found during my local compilation.
note: I can separate this commit to multiple commits if needed.