[Transformations][CPU] Introduce Convolution fusion with bias #29076
Conversation
github-actions
bot
added
category: CPU
aobolensk
force-pushed
the
fuse-bias
branch
9 times, most recently
from
2c87699 to
ce6fcca
Compare
src/core/shape_inference/include/convolution_shape_inference.hpp
Outdated
Show resolved
Hide resolved
|
Are there going to be any tests added for the added functionality? |
| namespace op { | ||
| namespace internal { | ||
|
|
||
| class TRANSFORMATIONS_API ConvolutionBiased : public ov::op::util::ConvolutionFwdPropBase { |
There was a problem hiding this comment.
TRANSFORMATIONS_API is usually used for exporting transformations, not operations.
There was a problem hiding this comment.
Hm, this is strange. I can see TRANSFORMATIONS_API macro usage in this context across many files in src/common/transformations/include/ov_ops dir. Do they also use that in incorrect way?
There was a problem hiding this comment.
I see, then we may re-do this in separate PR. Operation is not a transformation:)
There was a problem hiding this comment.
It should be TRANSFORMATIONS_API as it regards build target, not class category.
aobolensk
force-pushed
the
fuse-bias
branch
4 times, most recently
from
447e18b to
14089a2
Compare
...ormations/src/transformations/op_conversions/convert_convolution_to_convolution_internal.cpp
Outdated
Show resolved
Hide resolved
src/core/shape_inference/include/internal_convolution_shape_inference.hpp
Outdated
Show resolved
Hide resolved
| template <class TOp, | ||
| class TShape, | ||
| class TRShape = result_shape_t<TShape>, | ||
| typename std::enable_if<std::is_same<TOp, internal::Convolution>::value>::type* = nullptr> |
There was a problem hiding this comment.
the enable_if shoudl not be required just use internal::Convolution as type
...lugins/intel_cpu/tests/unit/shape_inference_test/convolution_biased_shape_inference_test.cpp
Outdated
Show resolved
Hide resolved
...lugins/intel_cpu/tests/unit/shape_inference_test/convolution_biased_shape_inference_test.cpp
Outdated
Show resolved
Hide resolved
aobolensk
force-pushed
the
fuse-bias
branch
2 times, most recently
from
9cbf58e to
53607e1
Compare
aobolensk
force-pushed
the
fuse-bias
branch
3 times, most recently
from
a2bf6e8 to
97c687e
Compare
|
This PR will be closed in a week because of 2 weeks of no activity. |
aobolensk
force-pushed
the
fuse-bias
branch
3 times, most recently
from
acfbc8d to
b5bd157
Compare
...ons/src/transformations/op_conversions/convert_group_convolution_to_convolution_internal.cpp
Outdated
Show resolved
Hide resolved
src/common/transformations/src/transformations/op_conversions/convolution_bias_fusion.cpp
Outdated
Show resolved
Hide resolved
src/common/transformations/src/transformations/op_conversions/convolution_bias_fusion.cpp
Outdated
Show resolved
Hide resolved
src/common/transformations/src/transformations/op_conversions/convolution_bias_fusion.cpp
Outdated
Show resolved
Hide resolved
aobolensk
force-pushed
the
fuse-bias
branch
2 times, most recently
from
b5114b4 to
7673915
Compare
| } | ||
|
|
||
| bool Convolution::has_groups() const { | ||
| return m_groups > 0; |
There was a problem hiding this comment.
Looks like not used can be removed
|
This PR will be closed in a week because of 2 weeks of no activity. |
|
This PR was closed because it has been stalled for 2 week with no activity. |
Details:
Tickets: