Attributes matching in a pattern #29132
Open
+648
−91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Evgeniia Nugmanova <[email protected]>
github-actions
bot
added
category: Core
Signed-off-by: Evgeniia Nugmanova <[email protected]>
Signed-off-by: Evgeniia Nugmanova <[email protected]>
…intel/openvino into attribute_pattern_matching Signed-off-by: Evgeniia Nugmanova <[email protected]>
Signed-off-by: Evgeniia Nugmanova <[email protected]>
…_matching Signed-off-by: Evgeniia Nugmanova <[email protected]>
…ed to introduce uselessattr predicate Signed-off-by: Evgeniia Nugmanova <[email protected]>
…_matching Signed-off-by: Evgeniia Nugmanova <[email protected]>
Signed-off-by: Evgeniia Nugmanova <[email protected]>
Signed-off-by: Evgeniia Nugmanova <[email protected]>
Signed-off-by: Evgeniia Nugmanova <[email protected]>
…3051 Signed-off-by: Evgeniia Nugmanova <[email protected]>
Signed-off-by: Evgeniia Nugmanova <[email protected]>
Signed-off-by: Evgeniia Nugmanova <[email protected]>
…_matching Signed-off-by: Evgeniia Nugmanova <[email protected]>
praasz
reviewed
Mar 4, 2025
…_matching Signed-off-by: Evgeniia Nugmanova <[email protected]>
…_matching Signed-off-by: Evgeniia Nugmanova <[email protected]>
|
This PR will be closed in a week because of 2 weeks of no activity. |
…intel/openvino into attribute_pattern_matching Signed-off-by: Evgeniia Nugmanova <[email protected]>
Signed-off-by: Evgeniia Nugmanova <[email protected]>
Signed-off-by: Evgeniia Nugmanova <[email protected]>
Signed-off-by: Evgeniia Nugmanova <[email protected]>
Signed-off-by: Evgeniia Nugmanova <[email protected]>
…_matching Signed-off-by: Evgeniia Nugmanova <[email protected]>
praasz
approved these changes
Apr 11, 2025
| } | ||
|
|
||
| private: | ||
| const Attributes& m_expected_attrs; |
There was a problem hiding this comment.
Use pointer or std::reference_wrapper to store attributes. There can be issues with copy/move semantic and default ctor is not possible.
Maybe some of these operation should be deleted.
Co-authored-by: Pawel Raasz <[email protected]>
…branch Signed-off-by: Evgeniia Nugmanova <[email protected]>
Signed-off-by: Evgeniia Nugmanova <[email protected]>
Signed-off-by: Evgeniia Nugmanova <[email protected]>
Signed-off-by: Evgeniia Nugmanova <[email protected]>
…branch Signed-off-by: Evgeniia Nugmanova <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
PredicateTickets: