Skip to content

[CPU] Add test case of setting model_distribution_policy to TENSOR_PARALLEL #29322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 25 commits into from
Jul 8, 2025
Merged

[CPU] Add test case of setting model_distribution_policy to TENSOR_PARALLEL #29322

merged 25 commits into from
Jul 8, 2025

Conversation

sunxiaoxia2022
Copy link
Contributor

@sunxiaoxia2022 sunxiaoxia2022 commented Mar 7, 2025 •
edited
Loading

Details:

  • add test case of model_distribution_policy is TENSOR_PARALLEL
  • Enable "ov::hint::ModelDistributionPolicy::TENSOR_PARALLEL" on single socket will create duplicated sub stream for functionality validation

Tickets:

@sunxiaoxia2022 sunxiaoxia2022 requested a review from wangleis March 7, 2025 07:22
@sunxiaoxia2022 sunxiaoxia2022 requested review from a team as code owners March 7, 2025 07:22
@github-actions github-actions bot added the category: CPU OpenVINO CPU plugin label Mar 7, 2025
@sunxiaoxia2022 sunxiaoxia2022 changed the title [CPU] Add test case of model_distribution_policy is TENSOR_PARALLEL [CPU] Add test case of setting model_distribution_policy to TENSOR_PARALLEL Mar 7, 2025
@sunxiaoxia2022 sunxiaoxia2022 requested a review from a team as a code owner March 13, 2025 07:37
@github-actions github-actions bot added the category: inference OpenVINO Runtime library - Inference label Mar 13, 2025
@peterchen-intel peterchen-intel mentioned this pull request Mar 14, 2025
Closed
@dmitry-gorokhov dmitry-gorokhov added this to the 2025.2 milestone Mar 24, 2025
@dmitry-gorokhov dmitry-gorokhov self-assigned this Mar 24, 2025
dmitry-gorokhov
dmitry-gorokhov reviewed Mar 24, 2025
View reviewed changes
src/plugins/intel_cpu/tests/functional/custom/behavior/ov_executable_network/properties.cpp Outdated
ASSERT_EQ(model_distribution_policy_value, setModels);
}

TEST_F(OVClassConfigTestCPU, smoke_CpuModelDistributionPolicyTensorParallelAccurcay) {
Copy link

@dmitry-gorokhov dmitry-gorokhov Mar 24, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It has to be usual functional subgraph test, which already have all the infra for output comparision and inputs filling.
Besides that we have to cover cases like matmul with compressed weights.
It also worth to verify execution graph to make sure TP was actually applied

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I added test case about TP to mat_mul.cpp and shared_matmul_weights_decompression.cpp. Please have a look.

@sunxiaoxia2022 sunxiaoxia2022 requested review from a team as code owners March 26, 2025 12:47
@github-actions github-actions bot added category: IE Tests OpenVINO Test: plugins and common category: GPU OpenVINO GPU plugin labels Mar 26, 2025
@wangleis wangleis requested review from praasz, maxnick and wangleis May 29, 2025 08:26
@praasz praasz modified the milestones: 2025.2, 2025.3 Jun 2, 2025
@github-actions GitHub Actions
Copy link
Contributor

This PR will be closed in a week because of 2 weeks of no activity.

@github-actions github-actions bot added the Stale label Jun 21, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 1, 2025

This PR was closed because it has been stalled for 2 week with no activity.

@github-actions github-actions bot closed this Jul 1, 2025
@wangleis wangleis reopened this Jul 2, 2025
@github-actions github-actions bot removed the Stale label Jul 3, 2025
@maxnick
Copy link
Contributor

maxnick commented Jul 7, 2025

@sunxiaoxia2022, could you please resolve merge conflicts?

@maxnick
Copy link
Contributor

maxnick commented Jul 7, 2025

@EgorDuplensky , do you have any further comments or suggestions?

@maxnick maxnick enabled auto-merge July 8, 2025 10:22
@maxnick maxnick removed the category: GPU OpenVINO GPU plugin label Jul 8, 2025
@maxnick maxnick added this pull request to the merge queue Jul 8, 2025
Merged via the queue into openvinotoolkit:master with commit aa1bb58 Jul 8, 2025
206 of 208 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wangleis wangleis wangleis approved these changes

@EgorDuplensky EgorDuplensky EgorDuplensky approved these changes

@maxnick maxnick maxnick approved these changes

@praasz praasz praasz approved these changes

@peterchen-intel peterchen-intel Awaiting requested review from peterchen-intel

@dmitry-gorokhov dmitry-gorokhov Awaiting requested review from dmitry-gorokhov

@azhai219 azhai219 Awaiting requested review from azhai219

Assignees

@maxnick maxnick

Labels
category: CPU OpenVINO CPU plugin category: IE Tests OpenVINO Test: plugins and common category: inference OpenVINO Runtime library - Inference
Projects
None yet
Milestone
2025.3
Development

Successfully merging this pull request may close these issues.
6 participants
@sunxiaoxia2022 @EgorDuplensky @wangleis @maxnick @dmitry-gorokhov @praasz