-
Notifications
You must be signed in to change notification settings - Fork 2.6k
[CPU] Add test case of setting model_distribution_policy to TENSOR_PARALLEL #29322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
[CPU] Add test case of setting model_distribution_policy to TENSOR_PARALLEL #29322
Conversation
ASSERT_EQ(model_distribution_policy_value, setModels); | ||
} | ||
|
||
TEST_F(OVClassConfigTestCPU, smoke_CpuModelDistributionPolicyTensorParallelAccurcay) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It has to be usual functional subgraph test, which already have all the infra for output comparision and inputs filling.
Besides that we have to cover cases like matmul with compressed weights.
It also worth to verify execution graph to make sure TP was actually applied
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I added test case about TP to mat_mul.cpp
and shared_matmul_weights_decompression.cpp
. Please have a look.
@sunxiaoxia2022 Does it mean we allow setting TP on any single socket machine even for Release package? Are there any potential performance degradations because of that? I understand that is done just to enable testing of the feature but having it always available in API can have potential negative impact. |
@EgorDuplensky Yes, it allow setting TP on single socket machine even for release package. Since TP is disabled by default, this change will not impact default behavior. If the user mistakenly sets TP for real inference on a single-slot platform, negative impact is expected. |
Details:
Tickets: