Skip to content

Implement Col2im primitive and support relevant models #29529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 30 commits into
base: master
Choose a base branch
from
Open

Implement Col2im primitive and support relevant models #29529

wants to merge 30 commits into from
+1,077 −20

Conversation

byungilm
Copy link
Contributor

@byungilm byungilm commented Mar 18, 2025 •
edited
Loading

Details:

  • Add col2im primitive for GPU (reference kernel)
  • Fix bug in reorder_inputs
  • Fix acc issue in prelu fusing

Tickets:

@github-actions github-actions bot added the category: GPU OpenVINO GPU plugin label Mar 18, 2025
@byungilm byungilm force-pushed the col2im branch 3 times, most recently from 79da69c to d10be36 Compare March 20, 2025 17:13
@byungilm byungilm marked this pull request as ready for review March 21, 2025 07:51
@byungilm byungilm requested review from a team as code owners March 21, 2025 07:52
@byungilm byungilm force-pushed the col2im branch 4 times, most recently from 68b2ab7 to f449468 Compare March 26, 2025 16:42
byungilm and others added 14 commits March 27, 2025 02:14
@byungilm
[GPU] Implement col2im
9af86eb 
Signed-off-by: Min, Byungil <[email protected]>
@isanghao @byungilm
fix for build
ad115ad
@isanghao @byungilm
keep three inputs for shape inference
c0ad041
@isanghao @byungilm
col2im shape_infer succeeds. Not sure whether it is correct or not
e7421cd
@isanghao @byungilm
now ocl build fails
f5524a1
@byungilm
[GPU] Implement col2im reference kernel
114b2ea 
Signed-off-by: Min, Byungil <[email protected]>
@byungilm
[GPU] Init draft for col2im opt kernel
8475c23 
Signed-off-by: Min, Byungil <[email protected]>
@byungilm
Update col2im opt kernel
f6d8d8c 
Signed-off-by: Min, Byungil <[email protected]>
@isanghao @byungilm
[GPU] reorder_inputs fixed
28070b9 
* get_target_output_format was checking wrong output port index
* insert_reorders_in_dir was skipping based on fmt_map. But fmt_map may not be up-to-date.
@byungilm
[GPU] update calc_output_layout for col_to_im
b7c241a 
Signed-off-by: Min, Byungil <[email protected]>
@byungilm
[GPU] Resolve acc issue by fusing prelu
d09c64b 
Signed-off-by: Min, Byungil <[email protected]>
@byungilm
[GPU] Fix conv fusing logic
cbd3fc2 
Signed-off-by: Min, Byungil <[email protected]>
@byungilm
[GPU] clear cpplint
8dd80b8 
Signed-off-by: Min, Byungil <[email protected]>
@byungilm
[GPU] Added unit-test for col-to-im
e1ecf28 
Signed-off-by: Min, Byungil <[email protected]>
byungilm added 2 commits March 27, 2025 02:27
@byungilm
[GPU] Fix comment for prelu fusing
7c12840 
Signed-off-by: Min, Byungil <[email protected]>
@byungilm
[GPU] clear cpplint
31554ba 
Signed-off-by: Min, Byungil <[email protected]>
@byungilm byungilm changed the title Implement Col2im primitive Implement Col2im primitive and support relevant models Mar 27, 2025
@byungilm byungilm requested a review from a team as a code owner March 27, 2025 17:19
@github-actions github-actions bot added the category: Core OpenVINO Core (aka ngraph) label Mar 27, 2025
byungilm added 3 commits March 28, 2025 03:10
@byungilm
[GPU] Fix unit-tests for col_to_im
6407f86 
Signed-off-by: Min, Byungil <[email protected]>
@byungilm
[GPU] Changed naming col_to_im
a716b5e 
Signed-off-by: Min, Byungil <[email protected]>
@byungilm
[GPU] Removed needs_calculate_L
3f08feb 
+ Added set attributes of v15::col2im for validation

Signed-off-by: Min, Byungil <[email protected]>
@github-actions github-actions bot added the category: CPP API OpenVINO CPP API bindings label Mar 31, 2025
@byungilm
[GPU] Bugfix and add func test for col2im
5ec5b70 
+ Bugfix for non-batched static shape input
+ Added func tests

Signed-off-by: Min, Byungil <[email protected]>
@byungilm byungilm requested review from a team as code owners April 2, 2025 09:53
@github-actions github-actions bot added the category: IE Tests OpenVINO Test: plugins and common label Apr 2, 2025
byungilm added 3 commits April 3, 2025 15:54
@byungilm
[GPU] Fixed CI failure
e200492 
Signed-off-by: Min, Byungil <[email protected]>
@byungilm
[GPU] Implement col2im to ocl_v2
93f0cf5 
Signed-off-by: Min, Byungil <[email protected]>
@byungilm
[GPU] modified calc_output_layout to use shape_infer
d87f144 
+ modified calc_output_layout
+ accuracy issue fix by ocl_v2 impl

Signed-off-by: Min, Byungil <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
category: Core OpenVINO Core (aka ngraph) category: CPP API OpenVINO CPP API bindings category: GPU OpenVINO GPU plugin category: IE Tests OpenVINO Test: plugins and common do not merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@byungilm @isanghao