[Core] Fix WeightlessCacheAttribute not being serialized
#29579
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-jankowski
approved these changes
Mar 19, 2025
praasz
approved these changes
Mar 20, 2025
|
|
||
| bool is_copyable() const override; | ||
|
|
||
| bool visit_attributes(AttributeVisitor& visitor) override; |
Contributor
There was a problem hiding this comment.
Can some test be added in src/core/tests/pass/serialization/serialize.cpp
|
|
||
| auto s_model = ov::test::readModel(m_out_xml_path, m_out_bin_path); | ||
| for (auto&& ov_node : s_model->get_ops()) { | ||
| if (auto it_weightless_cache_attribute = |
Contributor
There was a problem hiding this comment.
Shouldn't we also check that this condition is true for expected nodes?
Contributor
|
This PR will be closed in a week because of 2 weeks of no activity. |
Contributor
|
This PR was closed because it has been stalled for 2 week with no activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
WeightlessCacheAttributewas skipped from serializing due tovisit_attributesmethod not implemented, falling back tobase class's
RuntimeAttribute::visit_attributeswhich always return false here: https://github.com/openvinotoolkit/openvino/blob/master/src/core/src/pass/serialize.cpp#L1076-L1077Tickets: