Skip to content

[ONNX] Aligned behavior of ONNX Frontend function Relu-6, 13, 14 with original framework #29627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

Phantom65536
Copy link

@Phantom65536 Phantom65536 commented Mar 21, 2025

#20564

  1. Differences between opsets: 1–6 involves a legacy attribute in opset 1; 6–13 and 13–14 involve differences in input types.
  2. Implemented relu support for opsets 6, 13, and 14 in relu.cpp.
  3. There were changes in ops_bridge.cpp, so I don't think relu functions need to be registered there. I couldn't find another file where other onnx frontend operations are registered, nor did I find any header files in src/frontends/onnx/frontend/src/op, so I didn’t make changes there.
  4. Created .prototxt test models for ReLU in src/frontends/onnx/test/models.
  5. Added ReLU-related test cases in onnx_import.in.cpp. All test cases passed for IE_CPU and INTERPRETER.
  6. Didn’t find any xfailed tests related to this issue or ReLU.

@Phantom65536 Phantom65536 requested a review from a team as a code owner March 21, 2025 22:13
@github-actions github-actions bot added the category: ONNX FE OpenVINO ONNX FrontEnd label Mar 21, 2025
@sys-openvino-ci sys-openvino-ci added the ExternalPR External contributor label Mar 21, 2025
@p-wysocki p-wysocki requested a review from gkrivor March 24, 2025 11:02
@p-wysocki
Copy link
Contributor

Thank you for the PR!

bump @gkrivor

@gkrivor gkrivor changed the title 2nd Fix to Issue #20564: Align behavior of ONNX Frontend function Relu-6, 13, 14 with original framework [ONNX] Aligned behavior of ONNX Frontend function Relu-6, 13, 14 with original framework Mar 26, 2025
@mlukasze
Copy link
Contributor

hey @Phantom65536
clang format checks failed, could you fix it, please?

@Phantom65536
Copy link
Author

I've fixed the clang formattings.

@Phantom65536
Copy link
Author

I already ran clang-format on the modified files so I'm not sure why the clang-format checks failed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: ONNX FE OpenVINO ONNX FrontEnd ExternalPR External contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Good First Issue]: Align behavior of ONNX Frontend function Relu-6, 13, 14 with original framework
5 participants