Skip to content

[CPU] fix CPU FullyConnected Node zeros value output issue #30197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 28, 2025
Merged

[CPU] fix CPU FullyConnected Node zeros value output issue #30197

merged 3 commits into from
Apr 28, 2025

Conversation

liubo-intel
Copy link
Contributor

Details:

  • CPU internal FullyConnected Node will use cached constant weights during inference, while this will make the output of this node always zero values when its weight 'constant_path' conatains 'RandomUniform' Operation. so need to change current 'constant_path' logic to keep use Matmul kernels for these cases.

Tickets:

@liubo-intel liubo-intel requested review from a team as code owners April 18, 2025 00:49
@liubo-intel liubo-intel requested review from itikhono and removed request for a team April 18, 2025 00:49
@github-actions github-actions bot added category: CPU OpenVINO CPU plugin category: transformations OpenVINO Runtime library - Transformations labels Apr 18, 2025
@liubo-intel
Copy link
Contributor Author

Hi, @luweizhou2016 : could you please help review this pr when you are free? thanks.

@yuxu42 yuxu42 mentioned this pull request Apr 18, 2025
Open
3 tasks
@liubo-intel liubo-intel force-pushed the liubo/fix_CPU_fc_node_zeros_value_issue branch from 7097b71 to 67ed238 Compare April 18, 2025 02:36
itikhono
itikhono reviewed Apr 22, 2025
View reviewed changes
@liubo-intel liubo-intel force-pushed the liubo/fix_CPU_fc_node_zeros_value_issue branch from 67ed238 to a737b06 Compare April 23, 2025 08:41
@maxnick maxnick self-assigned this Apr 25, 2025
@maxnick maxnick added this pull request to the merge queue Apr 28, 2025
Merged via the queue into openvinotoolkit:master with commit 7270940 Apr 28, 2025
213 of 218 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luweizhou2016 luweizhou2016 luweizhou2016 left review comments

@itikhono itikhono itikhono approved these changes

@maxnick maxnick maxnick approved these changes

Assignees

@luweizhou2016 luweizhou2016

@maxnick maxnick

Labels
category: CPU OpenVINO CPU plugin category: transformations OpenVINO Runtime library - Transformations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@liubo-intel @luweizhou2016 @itikhono @maxnick