Fix pyright errors in node-factory.py #30205
Open
+111
−45
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the type handling in the
_arguments_as_outputs
method:isinstance(argument, Output)
instead ofissubclass(type(argument), Output)
for proper instance checkingAdded proper type annotations and documentation:
add_extension
methodUpdated the corresponding stub file
node_factory.pyi
for consistency with the implementation:These changes resolve the Pyright errors related to type inconsistencies and improve the overall type safety of the code.
Fixes #30153