Skip to content

Fix the onnxfrontend didn't call DLLMain when exit #33641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sgbihu merged 3 commits into from
Jan 21, 2026
Merged

Fix the onnxfrontend didn't call DLLMain when exit #33641

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
45f6ed9
Fix the onnxfrontend didn't call DLLMain when exit
sgbihu Jan 16, 2026
5a034b3
Add comments based on code review
sgbihu Jan 17, 2026
ea1abf6
Merge branch 'master' into fix_shutdown_protobuf
dorloff Jan 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/frontends/common/shutdown_protobuf/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@

set(TARGET_NAME openvino_protobuf_shutdown)

add_library(${TARGET_NAME} STATIC shutdown_protobuf.cpp)
# Use OBJECT instead of STATIC to ensure DLLMain is invoked when the shared library is unloaded
add_library(${TARGET_NAME} OBJECT shutdown_protobuf.cpp)
Copy link
Contributor

@mvafin mvafin Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add comment here that it must be preserved as OBJECT and not STATIC for windows build.

Copy link
Contributor Author

@sgbihu sgbihu Jan 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added.


add_library(openvino::protobuf_shutdown ALIAS ${TARGET_NAME})
set_target_properties(${TARGET_NAME} PROPERTIES EXPORT_NAME protobuf_shutdown)
Expand Down
Loading