Skip to content

[GPU] Update condition of winograd kernel selection#33681

Open
wilson-seok wants to merge 1 commit intoopenvinotoolkit:masterfrom
wilson-seok:disable_winograd_conv
Open

[GPU] Update condition of winograd kernel selection#33681
wilson-seok wants to merge 1 commit intoopenvinotoolkit:masterfrom
wilson-seok:disable_winograd_conv

Conversation

@wilson-seok
Copy link
Contributor

@wilson-seok wilson-seok commented Jan 19, 2026

Description of the issue(symptom, root-cause, how it was resolved)

  • Winograd kernel selected convolution has wrong accuracy output.
  • Padding > 0 would affect to wrong accuracy.
  • Added padding check in should_use_winograd_2x3_s1()

The code and line that caused this issue (if it is not changed directly)

Reproduction step and snapshot (if applicable. Do not attach for customer model)

  • $ ./benchmark_app -d GPU.0 -m ~/task/cvs179212/ttybulew.ov.instance-segmentation-bug-001/model.xml -i ~/task/cvs179212/ttybulew.ov.instance-segmentation-bug-001/image.npy -hint none -nstreams 1 -nireq 1 -niter 1

Problematic graph

  • I
image

Checklist

  • Is it a proper fix? (not a workaround)
  • Did you include test case for this fix, if necessary?
  • Did you review existing test that can be extended to cover this scenario? Which test did you review?

Tickets:

  • 179212

@wilson-seok wilson-seok requested review from a team as code owners January 19, 2026 14:52
@github-actions github-actions bot added the category: GPU OpenVINO GPU plugin label Jan 19, 2026
|| any_not_one(prim->stride) // stride has to be 1x1 by definition
|| any_not_one(prim->dilation) // no support for dilation
|| !all_zeroes(prim->padding_begin) // no padding supported. padding could makes higher accuracy loss.
|| !all_zeroes(prim->padding_end) // no padding supported. padding could makes higher accuracy loss.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this difficult to add relevant test-cases?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@byungilm It's hard to create a proper test case about winograd kernel selection. Because the kernel requires byxf format and byfx format selection in get_preferred_format() depends on not only should_use_winograd_2x3_s1() but also +2 depth of convolution_byxf_opt().

@p-durandin p-durandin added this to the 2026.0 milestone Jan 22, 2026
@p-durandin p-durandin modified the milestones: 2026.0, 2026.1 Feb 10, 2026
@p-durandin p-durandin added this pull request to the merge queue Feb 10, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category: GPU OpenVINO GPU plugin

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants