[GPU] Update condition of winograd kernel selection#33681
Open
wilson-seok wants to merge 1 commit intoopenvinotoolkit:masterfrom
Open
[GPU] Update condition of winograd kernel selection#33681wilson-seok wants to merge 1 commit intoopenvinotoolkit:masterfrom
wilson-seok wants to merge 1 commit intoopenvinotoolkit:masterfrom
Conversation
byungilm
reviewed
Jan 20, 2026
| || any_not_one(prim->stride) // stride has to be 1x1 by definition | ||
| || any_not_one(prim->dilation) // no support for dilation | ||
| || !all_zeroes(prim->padding_begin) // no padding supported. padding could makes higher accuracy loss. | ||
| || !all_zeroes(prim->padding_end) // no padding supported. padding could makes higher accuracy loss. |
Contributor
There was a problem hiding this comment.
Is this difficult to add relevant test-cases?
Contributor
Author
There was a problem hiding this comment.
@byungilm It's hard to create a proper test case about winograd kernel selection. Because the kernel requires byxf format and byfx format selection in get_preferred_format() depends on not only should_use_winograd_2x3_s1() but also +2 depth of convolution_byxf_opt().
byungilm
approved these changes
Jan 20, 2026
p-durandin
approved these changes
Jan 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the issue(symptom, root-cause, how it was resolved)
The code and line that caused this issue (if it is not changed directly)
openvino/src/plugins/intel_gpu/src/graph/layout_optimizer.cpp
Line 487 in 43018d2
Reproduction step and snapshot (if applicable. Do not attach for customer model)
Problematic graph
Checklist
Tickets: