[GPU][TRANSFORMATIONS] Support RMS Normalization Fusion without Learnable Affine Parameters#33861
Merged
e-ddykim merged 13 commits intoopenvinotoolkit:masterfrom Feb 11, 2026
Merged
Conversation
ffcc2cc to
4f171cd
Compare
e-ddykim
reviewed
Jan 29, 2026
src/common/transformations/src/transformations/common_optimizations/rms_fusion.cpp
Outdated
Show resolved
Hide resolved
cb5fb50 to
b81eeee
Compare
e-ddykim
reviewed
Jan 29, 2026
ed3a4b9 to
1c481aa
Compare
e-ddykim
approved these changes
Jan 30, 2026
Contributor
e-ddykim
left a comment
There was a problem hiding this comment.
Looks good to me for the GPU part
d64f73e to
5068afd
Compare
Contributor
Author
|
@CuriousPanCake Could you review this PR? |
src/common/transformations/src/transformations/common_optimizations/rms_fusion.cpp
Outdated
Show resolved
Hide resolved
src/common/transformations/src/transformations/common_optimizations/rms_fusion.cpp
Show resolved
Hide resolved
src/common/transformations/src/transformations/common_optimizations/rms_fusion.cpp
Outdated
Show resolved
Hide resolved
src/common/transformations/src/transformations/common_optimizations/rms_fusion.cpp
Outdated
Show resolved
Hide resolved
src/common/transformations/tests/common_optimizations/rms_norm_decomposition_test.cpp
Show resolved
Hide resolved
CuriousPanCake
requested changes
Jan 30, 2026
183a896 to
c9a0bbb
Compare
c499127 to
e5ebd49
Compare
Contributor
Author
|
c9733df to
c284fb2
Compare
Contributor
Author
|
@CuriousPanCake Could you please review the updated code that apply your comments again? |
CuriousPanCake
approved these changes
Feb 9, 2026
src/common/transformations/src/transformations/common_optimizations/rms_fusion.cpp
Show resolved
Hide resolved
src/common/transformations/src/transformations/common_optimizations/rms_fusion.cpp
Outdated
Show resolved
Hide resolved
Contributor
|
LGTM from the transformations side |
7c95e50 to
6d0130e
Compare
18199cc to
67c9a7e
Compare
Signed-off-by: Andrew Park <andrew.park@intel.com>
Signed-off-by: Andrew Park <andrew.park@intel.com>
Naseer-010
pushed a commit
to Naseer-010/openvino
that referenced
this pull request
Feb 18, 2026
…able Affine Parameters (openvinotoolkit#33861) ### Details: - This PR enhances RMS normalization fusion to support pattern without learnable affine parameter (gamma), enabling optimization of transformer architecture like LTX-Video - The existing RMS fusion pass only supported pattern with constant gamma parameter. However, some transformer model (e.g., LTX-Video's attention layers) use RMS normalization followed by dynamic scaling operation where the scale factor is non-constant. These pattern was previously unfused, missing optimization opportunity - When `elementwise_affine=False` (equivalent to [Pytorch RMS's attribute](https://docs.pytorch.org/docs/stable/generated/torch.nn.modules.normalization.RMSNorm.html)), RMS normalization does not include learnable gamma parameters. The gamma is implicitly fixed to ones, reducing the decomposed graph pattern from: `x → Power(2) → ReduceMean → Add(eps) → Sqrt → Divide(1/√) → Multiply(x, 1/√) → Multiply(gamma) ` to: `x → Power(2) → ReduceMean → Add(eps) → Sqrt → Divide(1/√) → Multiply(x, 1/√) [NO gamma multiplication] ` <img width="648" height="924" alt="image-2026-01-26-22-53-05-973" src="https://github.com/user-attachments/assets/02b4580f-bbce-43ea-affd-438f0a5f4ea7" /> ### Tickets: - [CVS-179953](https://jira.devtools.intel.com/browse/CVS-179953) --------- Signed-off-by: Andrew Park <andrew.park@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details:
elementwise_affine=False(equivalent to Pytorch RMS's attribute), RMS normalization does not include learnable gamma parameters. The gamma is implicitly fixed to ones, reducing the decomposed graph patternfrom:
x → Power(2) → ReduceMean → Add(eps) → Sqrt → Divide(1/√) → Multiply(x, 1/√) → Multiply(gamma)to:
x → Power(2) → ReduceMean → Add(eps) → Sqrt → Divide(1/√) → Multiply(x, 1/√) [NO gamma multiplication]Tickets: