[CPU][DEBUG CAPS] Fix failure on models with dynamic type constant nodes by aobolensk · Pull Request #34000 · openvinotoolkit/openvino

aobolensk · 2026-02-06T14:22:19Z

Tickets:

N/A

EgorDuplensky · 2026-02-11T15:49:42Z

src/core/src/op/constant.cpp

+
+    template <ov::element::Type_t ET, typename std::enable_if<ET == element::dynamic>::type* = nullptr>
+    static result_type visit(const void* const ptr, const size_t index) {
+        return "";


what about result_type{} or {}

EgorDuplensky · 2026-02-11T16:53:33Z

src/core/src/op/constant.cpp

    }
+
+    template <ov::element::Type_t ET, typename std::enable_if<ET == element::dynamic>::type* = nullptr>
+    static result_type visit(const void* const ptr, const size_t num_elements, std::vector<std::string>& strs) {}


the variable names can be removed or [[maybe_unused]]

Removed variable names

Copilot

Pull request overview

Fixes ValuesToString / ValueToString failures when encountering ov::element::dynamic constants by adding dynamic-type handling to the visitor dispatch.

Changes:

Adds element::dynamic overloads for ValueToString and ValuesToString.
Expands IfTypeOf dispatch to include dynamic so dynamic constants don’t route to unsupported behavior.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-11T16:55:21Z

src/core/src/op/constant.cpp

    static result_type visit(const void* const ptr, const size_t index) {
        return element::iterator<ET>(ptr)[index];
    }
+
+    template <ov::element::Type_t ET, typename std::enable_if<ET == element::dynamic>::type* = nullptr>
+    static result_type visit(const void* const ptr, const size_t index) {
+        return {};
+    }


For ET == element::dynamic, both visit templates are viable (the unconstrained template also matches), which can lead to an ambiguous overload or still instantiate element::iterator<ET> for dynamic. Constrain the non-dynamic overload (e.g., ET != element::dynamic) or merge into a single template using if constexpr to avoid compiling the iterator path for dynamic.

Copilot · 2026-02-11T16:55:21Z

src/core/src/op/constant.cpp

    }
+
+    template <ov::element::Type_t ET, typename std::enable_if<ET == element::dynamic>::type* = nullptr>
+    static result_type visit(const void* const ptr, const size_t num_elements, std::vector<std::string>& strs) {}


The dynamic overload leaves strs unchanged, so get_value_strings() can return an empty vector even when shape_size(m_shape) is non-zero. This creates inconsistent behavior vs. other element types (which always append num_elements entries). Consider appending/resizing strs with num_elements placeholder strings (e.g., empty strings) so the output cardinality remains consistent.

Suggested change

static result_type visit(const void* const ptr, const size_t num_elements, std::vector<std::string>& strs) {}

static result_type visit(const void* const /*ptr*/,

const size_t num_elements,

std::vector<std::string>& strs) {

// For dynamic element type, we cannot obtain concrete values, but we still

// need to keep the output cardinality consistent with num_elements.

// Append num_elements placeholder (empty) strings.

strs.insert(strs.end(), num_elements, std::string{});

}

Copilot · 2026-02-11T16:55:21Z

src/core/src/op/constant.cpp

    }
+
+    template <ov::element::Type_t ET, typename std::enable_if<ET == element::dynamic>::type* = nullptr>
+    static result_type visit(const void* const ptr, const size_t num_elements, std::vector<std::string>& strs) {}


This empty-body overload will typically trigger unused-parameter warnings for ptr, num_elements, and strs. To keep builds warning-clean, either omit parameter names in the signature or explicitly mark them unused (e.g., (void)ptr;).

Suggested change

static result_type visit(const void* const ptr, const size_t num_elements, std::vector<std::string>& strs) {}

static result_type visit(const void* const ptr, const size_t num_elements, std::vector<std::string>& strs) {

(void)ptr;

(void)num_elements;

(void)strs;

}

Removed variable names instead

praasz · 2026-02-13T08:29:49Z

src/core/src/op/constant.cpp

        return element::iterator<ET>(ptr)[index];
    }
+
+    template <ov::element::Type_t ET, typename std::enable_if<ET == element::dynamic>::type* = nullptr>


Can you add test?
The constant cannot be created with dynamic type the could should be not required at all

The constant cannot be created with dynamic type the could should be not required at all

Actually we can and they are used. CPU plugin uses dynanic type constants with 0 shape

This is IR after CPU specific transformations

@praasz added tests

The dynamic type mean no data so still member which access data should throw as incorrect use.
The public IR shouldn't have such constant it looks like it has to be handled by CPU.

Reverted core changes and re-apply previous CPU-only solution

praasz · 2026-02-16T06:26:45Z

src/core/src/op/constant.cpp

    std::vector<std::string> out;
    using namespace ov::element;
-    IfTypeOf<SUPPORTED_ET, string>::apply<ValuesToString>(get_element_type(), get_data_ptr(), shape_size(m_shape), out);
+    IfTypeOf<SUPPORTED_ET, dynamic, string>::apply<ValuesToString>(get_element_type(),


The dynamic has to be remove, there still should be an exception

@EgorDuplensky shall we switch to the previous CPU-only related fix?

praasz · 2026-02-16T07:32:55Z

src/core/src/op/constant.cpp

        return element::iterator<ET>(ptr)[index];
    }
+
+    template <ov::element::Type_t ET, typename std::enable_if<ET == element::dynamic>::type* = nullptr>


The dynamic type mean no data so still member which access data should throw as incorrect use.
The public IR shouldn't have such constant it looks like it has to be handled by CPU.

praasz · 2026-02-18T06:25:11Z

src/plugins/intel_cpu/src/utils/debug_capabilities.cpp

+                        for (const auto& v : constop->get_value_strings()) {
+                            os << sep << v;
+                            sep = ",";
+                        }


Suggested change

for (const auto& v : constop->get_value_strings()) {

os << sep << v;

sep = ",";

}

os << ov::util::join(constop->get_value_strings(), ",");

Optional, or use default separator ", "?

Applied, thanks

### Details: Filling the testing gap for `dynamic` type constants observed in #34000 ### Tickets: - N/A

### Details: Filling the testing gap for `dynamic` type constants observed in openvinotoolkit#34000 ### Tickets: - N/A

…des (openvinotoolkit#34000) ### Tickets: - N/A

aobolensk requested review from a team as code owners February 6, 2026 14:22

aobolensk assigned EgorDuplensky Feb 6, 2026

github-actions bot added the category: CPU OpenVINO CPU plugin label Feb 6, 2026

aobolensk force-pushed the cpu-debug-dump-fix branch from 32ee451 to 795459e Compare February 11, 2026 15:31

aobolensk requested a review from a team as a code owner February 11, 2026 15:31

aobolensk changed the title ~~[CPU][DEBUG CAPS] Fix failure on models with dynamic type constant nodes~~ Fix ValuesToString failure on models with dynamic type constants Feb 11, 2026

github-actions bot added category: Core OpenVINO Core (aka ngraph) and removed category: CPU OpenVINO CPU plugin labels Feb 11, 2026

aobolensk removed request for a team February 11, 2026 15:31

EgorDuplensky reviewed Feb 11, 2026

View reviewed changes

EgorDuplensky approved these changes Feb 11, 2026

View reviewed changes

EgorDuplensky requested a review from Copilot February 11, 2026 16:53

Copilot AI reviewed Feb 11, 2026

View reviewed changes

aobolensk assigned praasz Feb 11, 2026

aobolensk force-pushed the cpu-debug-dump-fix branch from ca3a6b1 to d1f1d70 Compare February 11, 2026 17:00

praasz added the pr: needs tests PR needs tests updating label Feb 13, 2026

praasz requested changes Feb 13, 2026

View reviewed changes

aobolensk force-pushed the cpu-debug-dump-fix branch from 2c2a56b to 58819b2 Compare February 13, 2026 09:24

aobolensk requested a review from praasz February 13, 2026 10:30

praasz reviewed Feb 16, 2026

View reviewed changes

aobolensk mentioned this pull request Feb 16, 2026

[Core] Add dynamic constant tests #34144

Merged

aobolensk force-pushed the cpu-debug-dump-fix branch from fe54820 to 9e7a4f2 Compare February 17, 2026 06:53

github-actions bot added category: CPU OpenVINO CPU plugin and removed category: Core OpenVINO Core (aka ngraph) labels Feb 17, 2026

aobolensk changed the title ~~Fix ValuesToString failure on models with dynamic type constants~~ [CPU][DEBUG CAPS] Fix failure on models with dynamic type constant nodes Feb 17, 2026

aobolensk added 2 commits February 17, 2026 07:55

[CPU][DEBUG CAPS] Fix failure on models with dynamic type constant nodes

9e7a4f2

WA Copyright check

65cd17f

aobolensk requested a review from praasz February 17, 2026 08:18

praasz approved these changes Feb 18, 2026

View reviewed changes

praasz removed the pr: needs tests PR needs tests updating label Feb 18, 2026

praasz added this to the 2026.1 milestone Feb 18, 2026

aobolensk added 2 commits February 18, 2026 07:33

Address review comment

7039cf9

Merge branch 'master' into cpu-debug-dump-fix

e719e60

github-merge-queue bot pushed a commit that referenced this pull request Feb 18, 2026

[Core] Add dynamic constant tests (#34144)

9a87c4e

### Details: Filling the testing gap for `dynamic` type constants observed in #34000 ### Tickets: - N/A

Merge branch 'master' into cpu-debug-dump-fix

5e0766b

olpipi approved these changes Feb 18, 2026

View reviewed changes

aobolensk enabled auto-merge February 18, 2026 18:00

aobolensk added this pull request to the merge queue Feb 18, 2026

Naseer-010 pushed a commit to Naseer-010/openvino that referenced this pull request Feb 18, 2026

[Core] Add dynamic constant tests (openvinotoolkit#34144)

b305163

### Details: Filling the testing gap for `dynamic` type constants observed in openvinotoolkit#34000 ### Tickets: - N/A

Merged via the queue into openvinotoolkit:master with commit b817324 Feb 18, 2026
261 of 271 checks passed

aobolensk deleted the cpu-debug-dump-fix branch February 18, 2026 20:17

wilson-seok pushed a commit to wilson-seok/openvino that referenced this pull request Feb 19, 2026

[Core] Add dynamic constant tests (openvinotoolkit#34144)

adcf89c

### Details: Filling the testing gap for `dynamic` type constants observed in openvinotoolkit#34000 ### Tickets: - N/A

wilson-seok pushed a commit to wilson-seok/openvino that referenced this pull request Feb 19, 2026

[CPU][DEBUG CAPS] Fix failure on models with dynamic type constant no…

a958bf2

…des (openvinotoolkit#34000) ### Tickets: - N/A

-    static result_type visit(const void* const ptr, const size_t num_elements, std::vector<std::string>& strs) {}
+    static result_type visit(const void* const /*ptr*/,
+                             const size_t num_elements,
+                             std::vector<std::string>& strs) {
+        // For dynamic element type, we cannot obtain concrete values, but we still
+        // need to keep the output cardinality consistent with num_elements.
+        // Append num_elements placeholder (empty) strings.
+        strs.insert(strs.end(), num_elements, std::string{});
+    }

-    static result_type visit(const void* const ptr, const size_t num_elements, std::vector<std::string>& strs) {}
+    static result_type visit(const void* const ptr, const size_t num_elements, std::vector<std::string>& strs) {
+        (void)ptr;
+        (void)num_elements;
+        (void)strs;
+    }

Conversation

aobolensk commented Feb 6, 2026

Tickets:

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Feb 11, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 11, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 11, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants