[CPU][PA] Align bidirectional image attention and sliding window interaction with reference#35446
Merged
p-wysocki merged 4 commits intoopenvinotoolkit:masterfrom May 4, 2026
Merged
Conversation
pkowalc1
approved these changes
Apr 23, 2026
Contributor
|
@zhangYiIntel , could you please review? |
zhangYiIntel
approved these changes
Apr 30, 2026
Signed-off-by: p-wysocki <przemyslaw.wysocki@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details:
When both bidirectional image attention and a sliding window were active, the CPU plugin computed the attention start index as:
start_idx = image_group_end - sliding_windowWhereas the correct way to do it (implemented by transformers and GPU Plugin) is to not clip the image attention, but instead pass it as a whole block, no matter what the sliding window size is.
An example
Let's assume 6 image tokens and a sliding window of size 5.
Before the fix:
Attention mask:
[1, 6)- first token cutAfter the fix:
Attention mask:
[0, 6)- full groupIf attention mask is being calculated for a text token, the attention is regular causal/sliding window, no matter if previous tokens were image or text, which matches transformers implementation.
Tickets:
AI Assistance: