Skip to content

[CPU] fix: correct the isa selection by env MAX_CPU_ISA#35536

Open
azhai219 wants to merge 1 commit intoopenvinotoolkit:masterfrom
azhai219:az/fix_bin_conv
Open

[CPU] fix: correct the isa selection by env MAX_CPU_ISA#35536
azhai219 wants to merge 1 commit intoopenvinotoolkit:masterfrom
azhai219:az/fix_bin_conv

Conversation

@azhai219
Copy link
Copy Markdown
Contributor

@azhai219 azhai219 commented Apr 27, 2026

Details:

  • correct the right isa selection when setting MAX_CPU_ISA
  • ...

Tickets:

AI Assistance:

  • AI assistance used: no / yes
  • If yes, summarize how AI was used and what human validation was performed (build/tests/manual checks).

@EgorDuplensky
Copy link
Copy Markdown
Contributor

@azhai219 Please follow repositories commit subject naming / tagging convention
[CPU]

@azhai219 azhai219 changed the title cpu: fix: correct the isa selection by env MAX_CPU_ISA [CPU] fix: correct the isa selection by env MAX_CPU_ISA Apr 27, 2026
Copy link
Copy Markdown
Collaborator

@rkazants rkazants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add test? Also, I mention ticket that is already closed.

@maxnick maxnick added this to the 2026.2 milestone Apr 27, 2026
@maxnick
Copy link
Copy Markdown
Contributor

maxnick commented Apr 27, 2026

Can you please add test? Also, I mention ticket that is already closed.

We already have dedicated tests:
src/plugins/intel_cpu/tests/functional/shared_tests_instances/single_layer_tests/binary_convolution.cpp

The problem with this specific issues is that the Binary Convolution implementation doesn't support (and has never supported) ISA enforce through the runtime info (this technique is used for some other primitves to test all the available implementations using a single HW set). Therefore, to trigger the issue, the test must be run on a CPU with sse42 max ISA, which is a rare case.
Also please note that sse42 is an outdated ISA and is no longer supported in OpenVINO (see https://docs.openvino.ai/2026/about-openvino/release-notes-openvino.html#discontinued-in-2026)

@maxnick maxnick requested a review from rkazants April 27, 2026 16:41
@rkazants rkazants dismissed their stale review April 28, 2026 05:06

seems tests exist

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category: CPU OpenVINO CPU plugin

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants