[GPU] Fix reshape runtime padding propagation when cropped axis is dropped#35616
Merged
e-ddykim merged 1 commit intoopenvinotoolkit:masterfrom May 4, 2026
Merged
Conversation
11c3d64 to
90b1bf9
Compare
Co-authored-by: Copilot <copilot@github.com>
Contributor
Author
|
no performance regression on daily (LLM) test |
e-ddykim
approved these changes
May 4, 2026
Merged
via the queue into
openvinotoolkit:master
with commit May 4, 2026
540f6b2
186 of 188 checks passed
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the issue(symptom, root-cause, how it was resolved)
VariadicSplit (last axis, lengths [1,1,1,1])followed by base-modeReshapes that drop the cropped size-1 axis ([N,M,1] -> [N,M]).is_runtime_propagatable_padding()(last-axis crop branch), the trailing-dim matching loop exits immediately when the cropped axis is size 1, returning true even when the reshape removes that axis. With no output dim left to carry the crop's dynamic padding, the four sibling reshape outputs propagated zero padding and ended up aliased to the same base-buffer offset, so downstream consumers read interleaved channel data as if it were contiguous.matched_trailing_dims) and reject propagation when none were matched and the reshape reduces rank — i.e. the cropped axis is genuinely dropped. Identity reshapes that preserve it ([N,M,1] -> [N,M,1]) remain eligible.The code and line that caused this issue (if it is not changed directly)
src/plugins/intel_gpu/src/graph/include/reshape_inst.hReproduction step and snapshot (if applicable. Do not attach for customer model)
Problematic graph
Checklist
prepare_buffer_fusinginsrc/plugins/intel_gpu/tests/unit/passes/prepare_buffer_fusing_test.cpp(in-place crop / reshape padding tests)Tickets: