[LPT] Remove CMake GLOB from openvino_lpt library - #36616
Open
v-Golubev wants to merge 4 commits into
Open
Conversation
github-actions
Bot
added
category: build
github-actions
Bot
added
the
category: IE Tests
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes file(GLOB* ...)-based source/header discovery from Low Precision Transformations (LPT) CMake targets by replacing it with explicit source/header lists, making the build inputs deterministic and less sensitive to filesystem changes.
Changes:
- Replace
ov_add_target()-driven GLOBbing inov_lpt_modelswith explicitSOURCES/PUBLIC_HEADERSand directadd_library(). - Replace
ov_add_test_target()-driven GLOBbing in LPT tests with explicitSOURCES/HEADERSand directadd_executable()+add_test(). - Replace
file(GLOB_RECURSE ...)inopenvino_lp_transformationswith explicitLIBRARY_SRC/PUBLIC_HEADERSlists.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/tests/ov_helpers/ov_lpt_models/CMakeLists.txt |
Switch ov_lpt_models to explicit source/header lists (no GLOB). |
src/common/low_precision_transformations/tests/CMakeLists.txt |
Switch LPT test executable to explicit source list and manual test registration. |
src/common/low_precision_transformations/CMakeLists.txt |
Replace recursive source/header GLOBs with explicit lists for the LPT library. |
Contributor
Author
|
@praasz could you please take a look? |
praasz
reviewed
Jul 22, 2026
|
|
||
| set(TARGET_NAME ov_lp_transformations_tests) | ||
|
|
||
| ov_add_test_target( |
Contributor
There was a problem hiding this comment.
See core unit test target
This helper can be still used with different input.
Here is updated documentation and migration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tickets:
AI Assistance: