Skip to content

[openvino-langchain] Use applyChatTemplate in ChatOpenVINO #990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Retribution98 merged 4 commits into from
Sep 4, 2025
Merged

[openvino-langchain] Use applyChatTemplate in ChatOpenVINO #990

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
06712ec
[openvino-langchain] Use applyChatTemplate in ChatOpenVINO
Retribution98 Aug 21, 2025
6521f9a
Apply suggestions from code review
Retribution98 Aug 21, 2025
c438e98
Update after review
Retribution98 Sep 4, 2025
77d17ff
Merge branch 'master' into CVS_172173
Retribution98 Sep 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 18 additions & 7 deletions modules/openvino-langchain/src/chat_models.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,10 +38,19 @@ export class ChatOpenVINO extends SimpleChatModel {
_llmType() {
return 'OpenVINO';
}
private convertMessages(messages: BaseMessage[]): string {
return messages
.map((msg) => `${msg.getType().toUpperCase()}: "${msg.content}"`)
.join('\n');
private async convertMessages(messages: BaseMessage[]): Promise<string> {
const pipeline = await this.pipeline;
if (messages.length === 0) {
throw new Error('No messages provided.');
}

return pipeline.getTokenizer().applyChatTemplate(
messages.map(m => ({
role: m.getType(),
content: m.text,
})),
true,
'');
}
async _call(
messages: BaseMessage[],
Expand All @@ -68,6 +77,8 @@ export class ChatOpenVINO extends SimpleChatModel {

// generation option setup
const generateOptions: GenerationConfig = { ...this.generateOptions };
// to avoid a warning about result type
generateOptions['return_decoded_results'] = true;
if (options.stop) {
const set = new Set(options.stop);
generateOptions['stop_strings'] = set;
Expand All @@ -81,7 +92,7 @@ export class ChatOpenVINO extends SimpleChatModel {
return signal.aborted ? StreamingStatus.CANCEL : StreamingStatus.RUNNING;
};

const prompt = this.convertMessages(messages);
const prompt = await this.convertMessages(messages);

const result = await pipeline.generate(
prompt,
Expand All @@ -91,7 +102,7 @@ export class ChatOpenVINO extends SimpleChatModel {
// We need to throw an exception if the generation was canceled by a signal
signal.throwIfAborted();

return result;
return result.toString();
}

async *_streamResponseChunks(
Expand All @@ -100,7 +111,7 @@ export class ChatOpenVINO extends SimpleChatModel {
runManager?: CallbackManagerForLLMRun,
): AsyncGenerator<ChatGenerationChunk> {
const pipeline = await this.pipeline;
const prompt = this.convertMessages(messages);
const prompt = await this.convertMessages(messages);
const generator = pipeline.stream(
prompt,
this.generateOptions,
Expand Down
4 changes: 3 additions & 1 deletion modules/openvino-langchain/src/llms.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,8 @@ export class OpenVINO extends LLM {

// generation option setup
const generateOptions: GenerationConfig = { ...this.generateOptions };
// to avoid a warning about result type
generateOptions['return_decoded_results'] = true;
if (options.stop) {
const set = new Set(options.stop);
generateOptions.stop_strings = set;
Expand All @@ -80,7 +82,7 @@ export class OpenVINO extends LLM {
// We need to throw an exception if the generation was canceled by a signal
signal.throwIfAborted();

return result;
return result.toString();
}

async *_streamResponseChunks(
Expand Down
Loading