Skip to content

Conversation

@pj3iL
Copy link

@pj3iL pj3iL commented Dec 18, 2025

Enablement of the PointPillars model for OpenVino

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@EfimovIlia EfimovIlia requested a review from a team December 29, 2025 10:20
@aleksandr-mokrov
Copy link
Collaborator

@pj3iL, please avoid committing the entire pointpillars repository into the notebooks folder. Ideally, this directory should contain only the notebook itself, readme and minimal helper files. Instead, please use the clone_repo helper function to clone the upstream repository. You can use dynamically.https://github.com/openvinotoolkit/openvino_notebooks/blob/latest/notebooks/fireredtts2/fireredtts2.ipynb as a reference implementation.

@pj3iL pj3iL marked this pull request as draft January 9, 2026 03:01
@pj3iL pj3iL marked this pull request as ready for review January 9, 2026 06:19
@pj3iL
Copy link
Author

pj3iL commented Jan 9, 2026

@aleksandr-mokrov, Thank you for your input and the reference. I updated the PR. Please let me know, if I need to realign for anything else.

Copy link
Collaborator

@aleksandr-mokrov aleksandr-mokrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pj3iL could you add the notebook in .ci\skipped_notebooks.yml for unsupported python version and add look into speel_check action, check the words and check exceptions in .ci\spellcheck.pyspelling.wordlist.txt

@@ -0,0 +1,857 @@
{
Copy link
Collaborator

@aleksandr-mokrov aleksandr-mokrov Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line #4.      str(pp_dir / "requirements.txt"),

Please add --extra-index-url https://download.pytorch.org/whl/cpu to avoid installing unnecessary cuda-specific packages.


Reply via ReviewNB

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created PR in the main repo.

@pj3iL pj3iL marked this pull request as draft January 14, 2026 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants