-
Notifications
You must be signed in to change notification settings - Fork 964
pointpillars #3232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: latest
Are you sure you want to change the base?
pointpillars #3232
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
@pj3iL, please avoid committing the entire pointpillars repository into the notebooks folder. Ideally, this directory should contain only the notebook itself, readme and minimal helper files. Instead, please use the clone_repo helper function to clone the upstream repository. You can use dynamically.https://github.com/openvinotoolkit/openvino_notebooks/blob/latest/notebooks/fireredtts2/fireredtts2.ipynb as a reference implementation. |
|
@aleksandr-mokrov, Thank you for your input and the reference. I updated the PR. Please let me know, if I need to realign for anything else. |
aleksandr-mokrov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pj3iL could you add the notebook in .ci\skipped_notebooks.yml for unsupported python version and add look into speel_check action, check the words and check exceptions in .ci\spellcheck.pyspelling.wordlist.txt
| @@ -0,0 +1,857 @@ | |||
| { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line #4. str(pp_dir / "requirements.txt"),
Please add --extra-index-url https://download.pytorch.org/whl/cpu to avoid installing unnecessary cuda-specific packages.
Reply via ReviewNB
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Created PR in the main repo.
Enablement of the PointPillars model for OpenVino