pointpillars#3232
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
@pj3iL, please avoid committing the entire pointpillars repository into the notebooks folder. Ideally, this directory should contain only the notebook itself, readme and minimal helper files. Instead, please use the clone_repo helper function to clone the upstream repository. You can use dynamically.https://github.com/openvinotoolkit/openvino_notebooks/blob/latest/notebooks/fireredtts2/fireredtts2.ipynb as a reference implementation. |
|
@aleksandr-mokrov, Thank you for your input and the reference. I updated the PR. Please let me know, if I need to realign for anything else. |
aleksandr-mokrov
left a comment
There was a problem hiding this comment.
@pj3iL could you add the notebook in .ci\skipped_notebooks.yml for unsupported python version and add look into speel_check action, check the words and check exceptions in .ci\spellcheck.pyspelling.wordlist.txt
|
@aleksandr-mokrov, I incorporated the requested changes and fixed issues for metadata, scarf pixel, telemetry, toc, and install instruction. |
586c71d
into
openvinotoolkit:latest
Enablement of the PointPillars model for OpenVino