[New Notebook] Biological Texture Generation (Iris) using LCM & OpenVINO#3288
[New Notebook] Biological Texture Generation (Iris) using LCM & OpenVINO#3288humbeaniket2006-max wants to merge 2 commits intoopenvinotoolkit:latestfrom
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
Would you mind adding a README and (much) more documentation and descriptions, maybe including references, cites to papers or blogs, please, with example outputs with its example prompts (like reusing some from https://github.com/humbeaniket2006-max/Ocular_Core_Lite)? Have a look into e.g. "https://github.com/openvinotoolkit/openvino_notebooks/blob/latest/notebooks/hello-world/hello-world.ipynb" for how to typically install dependencies (e.g. Could you also add an inference device selection (CPU, GPU, VPU if supported), please? Do you really want to completely rely on the thirdparty call for model compilation and the inference, instead of demonstrating OpenVINO APIs within this notebook? Completely delegating everything to a 3rdparty tool/library and then "just call one method to do everything" makes this whole notebook... not so... exciting... and demonstrative? |
|
Thank you for the detailed feedback! I appreciate the guidance on alignment with the repository standards. I will start working on these changes immediately: 1.Adding a comprehensive README and more explanatory markdown/references in the notebook. 2.Adding the standard OpenVINO device selection widget. 3.Refactoring the pipeline to better demonstrate OpenVINO's specific capabilities (compilation and inference) rather than just abstracting it away. I'll push the updates soon! |
|
@jgespino do you want to comment as well? |
2048f63 to
3ff6dfa
Compare
|
Thanks for the feedback! I have refactored the notebook to address your points:
Ready for another look when you have a chance! |
|
@aleksandr-mokrov Could you please help assign to the team for review? |
|
@jgespino assigned, thank you for the PR! The team is off next week, so please expect a slight delay. We will be able to review the PR the week after next. |
|
Hi @humbeaniket2006-max thanks for your contribution. 2 questions:
|
|
Hi! Thanks for the review.
I believe this "UseCase-First" approach helps users understand how to apply OpenVINO to specific industry problems. |
| @@ -0,0 +1,106 @@ | |||
| { | |||
There was a problem hiding this comment.
Description:
This Pull Request adds a new notebook demonstrating the generation of high-fidelity biological textures, specifically iris patterns, using Latent Consistency Models (LCM) optimized with OpenVINO.
This notebook addresses the need for efficient, high-quality texture generation in medical imaging and biometric datasets, significantly reducing inference steps compared to traditional Latent Diffusion Models (LDMs).
Related Issue:
Closes #3241
Key Features:
Checklist:
%pip installin the first cell.README.mdcreated in the notebook folder.