feat: update Plonky3 #195
Merged
feat: update Plonky3 #195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zlangley
force-pushed
the
feat/update-plonky3
branch
10 times, most recently
from
db491c8 to
59c24a6
Compare
zlangley
force-pushed
the
feat/update-plonky3
branch
9 times, most recently
from
ab5520a to
07368a8
Compare
- Bumped rust toolchain to 1.90.0 to match Plonky3. - Bumped workspace `rand` to 0.9 to match Plonky3. - Swapped renamed traits and APIs: - `FieldAlgebra` → `PrimeCharacteristicRing` - `FieldExtensionAlgebra` → `BasedVectorSpace` - `sample_ext_element` → `sample_algebra_element` - `::D` → `::DIMENSION` - `from_canonical_*` → `from_*` - `monomial` → `ith_basis_element` (now returns `Option`) - `p3_fri::FriConfig` → `p3_fri::FriParameters` - `p3_bn254_fr` → `p3_bn254` - `Matrix::get` now returns `Option`, so matrix accesses unwrap with `copied()`/`expect`. - `SubMatrixRowSlices` was rewritten to conform to the new `Matrix` trait (no `Row` assoc type; explicit `get`/`row_subseq_unchecked`/`row_slice`). - `AB::Var` no longer implements `Copy`, and `AB::F` no longer implements `Field`, but we these trait bounds back in `InteractionBuilder.`
This reverts commit 07368a8.
jonathanpwang
force-pushed
the
feat/update-plonky3
branch
from
e147b8e to
59ca86e
Compare
|
|
||
| let (local, next) = (main.row_slice(0), main.row_slice(1)); | ||
| let (local, next) = ( | ||
| main.row_slice(0).expect("window should have two elements"), |
Contributor
There was a problem hiding this comment.
do we need to do this in every AIR?
jonathanpwang
approved these changes
Dec 17, 2025
Contributor
jonathanpwang
left a comment
jonathanpwang
left a comment
There was a problem hiding this comment.
LGTM
It is unfortunate that .row_slice(0) needs .unwrap(), but I think it is safer to unwrap than to use row_slice_unchecked, especially since we only use the AIR code for symbolic DAG extraction.
Contributor
|
This is merging into |
jonathanpwang
added a commit
to openvm-org/openvm
that referenced
this pull request
Dec 18, 2025
Updates to plonky3 v0.4.0. Syncs with openvm-org/stark-backend#195 closes INT-4245 --------- Co-authored-by: Jonathan Wang <[email protected]>
branch-rebase-bot bot
pushed a commit
to openvm-org/openvm
that referenced
this pull request
Dec 19, 2025
Updates to plonky3 v0.4.0. Syncs with openvm-org/stark-backend#195 closes INT-4245 --------- Co-authored-by: Jonathan Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.