OpenCL: Fix shared helper macro for creating a pinned buffer with fallback to malloc #5914
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fallback to malloc wasn't quite correct so when it kicked in the format would crash immediately. Now tested with faked failures and debug prints. Ten or so formats currently use these macros so will be improved by this fix.
magnumripper
force-pushed
the
opencl-pinned-memory-fallback
branch
from
e5c763b to
f0c9fe7
Compare
magnumripper
force-pushed
the
opencl-pinned-memory-fallback
branch
from
f0c9fe7 to
80547bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fallback code path wasn't correct, so when it kicked in the format would crash immediately. Now tested with faked failures and debug prints. Ten or so formats use this shared code so are affected.
In separate commit, revise cryptosafe-opencl to also use the macros.