feat(oauth2): bring wallet attestations to draft 9 - #255
Merged
Conversation
🦋 Changeset detectedLatest commit: 99eb438 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
hacdias
force-pushed
the
feat/wallet-attestations-draft-9
branch
from
July 1, 2026 13:14
c26d449 to
b22faf0
Compare
TimoGlastra
reviewed
Jul 1, 2026
| client_attestation_signing_alg_values_supported: z.optional(z.array(zAlgValueNotNone)), | ||
| client_attestation_pop_signing_alg_values_supported: z.optional(z.array(zAlgValueNotNone)), | ||
| // Endpoint from which the client can obtain a fresh challenge for the Client Attestation PoP JWT. | ||
| challenge_endpoint: z.optional(zHttpsUrl), |
Contributor
There was a problem hiding this comment.
so we now have nonce endpoint in oid4vci, and challenge endpoints for wallet attestation 😓
TimoGlastra
reviewed
Jul 1, 2026
Signed-off-by: Henrique Dias <mail@hacdias.com>
TimoGlastra
reviewed
Jul 1, 2026
TimoGlastra
approved these changes
Jul 1, 2026
Signed-off-by: Henrique Dias <mail@hacdias.com>
hacdias
force-pushed
the
feat/wallet-attestations-draft-9
branch
from
July 1, 2026 13:26
b22faf0 to
4112996
Compare
…se case The issuer option was framed as deprecated back-compat only. It has a legitimate ongoing use: when signing with a DID whose kid header is a relative fragment (e.g. '#key-1'), the iss value supplies the DID base used to reconstruct the full DID URL during verification. Reframe the JSDoc and drop the @deprecated tag.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the current implementation to support Draft 9 of wallet attestations in a backwards compatible way.
Maybe it's worth considering not doing it backwards compatible since it's a draft, and we can simplify a bit.