fix(openid4vci): cred issuer metadata correctly transformed to draft 16 - #90
Merged
Conversation
Signed-off-by: Henrique Dias <mail@hacdias.com>
🦋 Changeset detectedLatest commit: f252d5e The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Signed-off-by: Henrique Dias <mail@hacdias.com>
hacdias
marked this pull request as ready for review
August 18, 2025 07:40
6 tasks
Signed-off-by: Henrique Dias <mail@hacdias.com>
Signed-off-by: Henrique Dias <mail@hacdias.com>
hacdias
force-pushed
the
fix/metadata-issuer-cred
branch
from
August 19, 2025 08:40
abdf3e2 to
f824f0b
Compare
TimoGlastra
reviewed
Aug 20, 2025
TimoGlastra
reviewed
Aug 20, 2025
TimoGlastra
approved these changes
Aug 20, 2025
TimoGlastra
left a comment
TimoGlastra
left a comment
Contributor
There was a problem hiding this comment.
Some questions, but overall LGTM
Signed-off-by: Henrique Dias <mail@hacdias.com>
Member
Author
|
@TimoGlastra thanks for the review. Please check my latest commit where I:
|
TimoGlastra
approved these changes
Aug 20, 2025
manuraf
pushed a commit
to manuraf/oid4vc-ts
that referenced
this pull request
Oct 31, 2025
…16 (openwallet-foundation-labs#90) Signed-off-by: Henrique Dias <mail@hacdias.com> Signed-off-by: Manuel Rafeli <manuel.rafeli@pagopa.it>
manuraf
pushed a commit
to manuraf/oid4vc-ts
that referenced
this pull request
Oct 31, 2025
…16 (openwallet-foundation-labs#90) Signed-off-by: Henrique Dias <mail@hacdias.com> Signed-off-by: Manuel Rafeli <manuel.rafeli@pagopa.it>
manuraf
pushed a commit
to manuraf/oid4vc-ts
that referenced
this pull request
Oct 31, 2025
…16 (openwallet-foundation-labs#90) Signed-off-by: Henrique Dias <mail@hacdias.com> Signed-off-by: Manuel Rafeli <manuel.rafeli@pagopa.it>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the credential issuer metadata, which is now correctly transformed to the syntax of Draft 16. In addition, some typing issues have also been fixed which prevented to get the types of nested fields.