feat: add expo modules to the project #1524
Conversation
Signed-off-by: Mostafa Gamal <[email protected]>
🦋 Changeset detectedLatest commit: b33511c The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
jleach
changed the title
Signed-off-by: Mostafa Gamal <[email protected]>
Signed-off-by: Mostafa Gamal <[email protected]>
Signed-off-by: Mostafa Gamal <[email protected]>
Signed-off-by: Mostafa Gamal <[email protected]>
Signed-off-by: Mostafa Gamal <[email protected]>
Signed-off-by: Mostafa Gamal <[email protected]>
Signed-off-by: Mostafa Gamal <[email protected]>
Signed-off-by: Mostafa Gamal <[email protected]>
|
| "@unimodules/react-native-adapter": "file:./noop", | ||
| "@unimodules/core": "file:./noop", |
There was a problem hiding this comment.
this is an issue with credo it uses unsupported package tat you must exclude
issue described here
https://credo.js.org/guides/getting-started/set-up
| @@ -473,7 +545,7 @@ | |||
| "$(inherited)", | |||
| ); | |||
| INFOPLIST_FILE = AriesBifoldTests/Info.plist; | |||
| IPHONEOS_DEPLOYMENT_TARGET = 12.0; | |||
| IPHONEOS_DEPLOYMENT_TARGET = 13.4; | |||
There was a problem hiding this comment.
can we avoid this bump?
There was a problem hiding this comment.
I believe I came across this and expo failed to build until I bump up the version
There was a problem hiding this comment.
I think we should at least try to keep the latest 12.x version supported, it's a non-negligible percentage of iOS users
There was a problem hiding this comment.
Researched this a bit, seems like it's pretty difficult to support lower versions than the default lowest Expo comes with... I'll bring it up to the BC Team
There was a problem hiding this comment.
Take a look at that
[20:44:40]: Application Loader output above ^
[20:44:40]: ERROR: [ContentDelivery.Uploader] Validation failed (409) SDK version issue. This app was built with the iOS 17.5 SDK. All iOS and iPadOS apps must be built with the iOS 18 SDK or later, included in Xcode 16 or later, in order to be uploaded to App Store Connect or submitted for distribution. (ID: a7efe6f5-62e0-42cc-be04-2cdbadd22e95)
Now apple requires minimum target version to be 1OS 18.
There was a problem hiding this comment.
just thought to leave a comment :D about this it is about the built SDK not the minimum IOS deployment version so it is just about which Xcode version you are using it should be 16+ and you can find the SDK version beside simulator and it will be shown in the metadata when you submit that is why it would be rejected on app store @MosCD3
There was a problem hiding this comment.
as for why you need to bump it up it is mentioned in expo SDK 50 changelog Expo 50
tldr : the iOS minimum deployment target should be bumped to 13.4
| @@ -51,6 +51,8 @@ | |||
| "@react-navigation/stack": "^6.3.21", | |||
| "axios": "^1.4.0", | |||
| "base-64": "^1.0.0", | |||
| "expo": "~50.0.0", | |||
There was a problem hiding this comment.
patch version could be 50.0.20, no?
There was a problem hiding this comment.
you think this will work, can give it a shot but you will be responsible for wwIII
Summary of Changes
Screenshots, videos, or gifs
Replace this text with embedded media for UI changes if they are included in this PR. If there are none, simply enter N/A
Breaking change guide
Replace this text with any breaking changes included in this PR along with how to address them in downstream projects. If there are none, simply enter N/A
Related Issues
Replace this text with issue #'s that are relevant to this PR. If there are none, simply enter N/A
Pull Request Checklist
Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.
Signed-off-byline (we use the DCO GitHub app to enforce this)If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!
Pro Tip 🤓