Fix card focus transitions and scroll offset synchronization on iOS. - #1970
Merged
Conversation
Update `VerticalCardList` on iOS to properly synchronize scroll offsets and focus states during card transitions: - Update `ScrollViewObserver` to synchronize `UIScrollView`'s content offset with `scrollOffset` without artificial clamping or dropping updates when top insets are still resolving. - Only update `scrollOffset` in the observer when the user is actively dragging or decelerating to avoid clobbering existing scroll offsets when pushing new destination views onto a navigation stack. - Correctly resolve `effectiveFocusedId` and `internalFocusedCard` during reverse animations so unfocusing smoothly animates in-place. - Ensure `internalFocusedCardIdentifier` initializes immediately on appear when the focused card is already set. Fixes #1961. (For real, this time, again.) Test: Verified card focusing, unfocusing, and scrolling behavior in SwiftTestApp and Multipaz Wallet on iOS Simulator and iPhone 15 Pro. Signed-off-by: David Zeuthen <zeuthen@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update
VerticalCardListon iOS to properly synchronize scroll offsets and focus states during card transitions:ScrollViewObserverto synchronizeUIScrollView's content offset withscrollOffsetwithout artificial clamping or dropping updates when top insets are still resolving.scrollOffsetin the observer when the user is actively dragging or decelerating to avoid clobbering existing scroll offsets when pushing new destination views onto a navigation stack.effectiveFocusedIdandinternalFocusedCardduring reverse animations so unfocusing smoothly animates in-place.internalFocusedCardIdentifierinitializes immediately on appear when the focused card is already set.Fixes #1961. (For real, this time, again.)
Test: Verified card focusing, unfocusing, and scrolling behavior in
SwiftTestApp and Multipaz Wallet on iOS Simulator and iPhone 15 Pro.