Skip to content

feat: credo as holder and jsonld issuance + verification#80

Open
GHkrishna wants to merge 28 commits into
openwallet-foundation:mainfrom
GHkrishna:feat/credo-holder-jsonld-issuance
Open

feat: credo as holder and jsonld issuance + verification#80
GHkrishna wants to merge 28 commits into
openwallet-foundation:mainfrom
GHkrishna:feat/credo-holder-jsonld-issuance

Conversation

@GHkrishna

Copy link
Copy Markdown
Contributor

What:

  • Add Credo support instead of older AFJ
  • Add JSONLD issuance and verification support

@GHkrishna GHkrishna force-pushed the feat/credo-holder-jsonld-issuance branch 3 times, most recently from e61c8a7 to 3d785ea Compare November 15, 2024 12:01

@anwalker293 anwalker293 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @GHkrishna! We have a PR already approved (waiting on one change) to move from AFJ to credo as the holder. Could you just make this PR for jsonLD issuance and verification please? And can you please remove the Indicio-demonet files from everything? (The demonet for Indicio won't work / requires manual approval to anchor an endorser DID)

@GHkrishna

GHkrishna commented Nov 19, 2024

Copy link
Copy Markdown
Contributor Author

Actually most of the testing for JSON-LD(issuance/verification) has been done with Credo and not AFJ, so will it be okay to keep the changes in the PR as is and only merge this PR when the credo as holder PR merges.

@anwalker293

Copy link
Copy Markdown
Contributor

@GHkrishna Credo has been merged into owl-akrida

@GHkrishna

Copy link
Copy Markdown
Contributor Author

Sure, had some minor changes, will sync

Signed-off-by: Krishna Waske <krishna.waske@ayanworks.com>
Signed-off-by: Krishna Waske <krishna.waske@ayanworks.com>
Signed-off-by: Krishna Waske <krishna.waske@ayanworks.com>
Signed-off-by: Krishna Waske <krishna.waske@ayanworks.com>
Signed-off-by: Krishna Waske <krishna.waske@ayanworks.com>
Signed-off-by: Krishna Waske <krishna.waske@ayanworks.com>
Signed-off-by: Krishna Waske <krishna.waske@ayanworks.com>
Signed-off-by: Krishna Waske <krishna.waske@ayanworks.com>
Signed-off-by: Krishna Waske <krishna.waske@ayanworks.com>
Signed-off-by: Krishna Waske <krishna.waske@ayanworks.com>
Signed-off-by: Krishna Waske <krishna.waske@ayanworks.com>
Signed-off-by: Krishna Waske <krishna.waske@ayanworks.com>
Signed-off-by: Krishna Waske <krishna.waske@ayanworks.com>
Signed-off-by: Krishna Waske <krishna.waske@ayanworks.com>
Signed-off-by: Krishna Waske <krishna.waske@ayanworks.com>
Signed-off-by: Krishna Waske <krishna.waske@ayanworks.com>
Signed-off-by: Krishna Waske <krishna.waske@ayanworks.com>
Signed-off-by: Krishna Waske <krishna.waske@ayanworks.com>
Signed-off-by: Krishna Waske <krishna.waske@ayanworks.com>
Signed-off-by: Krishna Waske <krishna.waske@ayanworks.com>
Signed-off-by: Krishna Waske <krishna.waske@ayanworks.com>
Signed-off-by: Krishna Waske <krishna.waske@ayanworks.com>
Signed-off-by: Krishna Waske <krishna.waske@ayanworks.com>
Signed-off-by: Krishna Waske <krishna.waske@ayanworks.com>
Signed-off-by: Krishna Waske <krishna.waske@ayanworks.com>
Signed-off-by: Krishna Waske <krishna.waske@ayanworks.com>
Signed-off-by: Krishna Waske <krishna.waske@ayanworks.com>
Signed-off-by: Krishna Waske <krishna.waske@ayanworks.com>
@GHkrishna GHkrishna force-pushed the feat/credo-holder-jsonld-issuance branch from e85b5c5 to 8eeb406 Compare December 2, 2024 07:57
@GHkrishna

GHkrishna commented Dec 2, 2024

Copy link
Copy Markdown
Contributor Author

I have updated the branch and made some changes, however I m facing some issues with schema interoperability between ACA-py and credo specifically for verification. Issuance works fine.
Not sure, if we can merge it until we figure that out or wait for its resolution, need your suggestion. I'll update the detailed error

@anwalker293

Copy link
Copy Markdown
Contributor

@GHkrishna Could we have more information on what you're seeing? re: schemas

@GHkrishna

GHkrishna commented Dec 3, 2024

Copy link
Copy Markdown
Contributor Author

In ACA-py, according to this resource the uri for schema in presentation request is https://w3id.org/citizenship#PermanentResident however in credo its only https://w3id.org/citizenship for this example. This causes issue with schema resolution on credo's side

@PatStLouis

PatStLouis commented Sep 25, 2025

Copy link
Copy Markdown
Contributor

Discussed on 2025-09-25: @PatStLouis said this is important, should test vcdm 1.1 and 2.0 with different cryptosuites. @KimEbert42 we might want to use the new issuer/verifier agent setup. This PR needs to be revisited.

@PatStLouis mentioned it might be a good idea to keep status list in mind when revisiting this.

@PatStLouis

Copy link
Copy Markdown
Contributor

@GHkrishna could you rebase this PR please?

@GHkrishna

GHkrishna commented Nov 24, 2025

Copy link
Copy Markdown
Contributor Author

@GHkrishna could you rebase this PR please?

Yes sure

@GHkrishna GHkrishna self-assigned this Nov 24, 2025
@PatStLouis

Copy link
Copy Markdown
Contributor

@GHkrishna any updates on the rebase?

@GHkrishna

Copy link
Copy Markdown
Contributor Author

Hi @PatStLouis

I did rebase the branch. But I noticed we have changed the structure a bit. I need to update the imports and the logic tiny bit, which I'll do at the soonest. Have been a bit occupied with other commitments.

@PatStLouis

Copy link
Copy Markdown
Contributor

discussed: keeping open for reference, will likely re implement with new architecture in seperate pr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants