Improved implementation in terms of creating all Serial objects available, for a given MCU. (#91) #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michpro
force-pushed
the
FIX-91_No_Serial_objects
branch
from
f0097ce to
c6c920d
Compare
TianpeiLee
reviewed
Jun 5, 2024
TianpeiLee
requested changes
Jun 5, 2024
| @@ -67,45 +67,29 @@ | |||
| #endif /* !HWSERIAL_NONE && SERIAL_UART_INSTANCE */ | |||
|
|
|||
|
|
|||
| #if defined(ENABLE_HWSERIAL1) | |||
There was a problem hiding this comment.
Is it necessary to remove the definition of ENABLE_HWSERIALx here for it to take effect?
There was a problem hiding this comment.
OK, maybe this is a “too fast” workaround,... it would be best to edit all the “variant_CH32xxx.h” files and change the definitions in them '#define SERIAL_UART_INSTANCE 1' to '#define SERIAL_UART_INSTANCE “n”' where “n” is the number of available U(S)ART for a given MCU.
TianpeiLee
added a commit
that referenced
this pull request
Jun 5, 2024
maxint-rd
added a commit
to maxint-rd/arduino_core_ch32
that referenced
this pull request
Jul 28, 2024
maxint-rd
added a commit
to maxint-rd/arduino_core_ch32
that referenced
this pull request
Jul 28, 2024
atollminsk
added a commit
to atollminsk/arduino_core_ch32
that referenced
this pull request
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.