Skip to content

Enable setting retention to trait fields #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Enable setting retention to trait fields #41

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions wdl/wdl_options.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,8 @@ import "google/protobuf/descriptor.proto";
import "google/protobuf/any.proto";
import "google/protobuf/duration.proto";
import "google/protobuf/timestamp.proto";
import public "storage/datapol/annotations/proto/semantic_annotations.proto";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I remember when @mrjerryjohns scrubbed OpenWeave WDLC, these two Protobuf headers are Google-internal-only and are not open source and, consequently, are not appropriate to introduce as external dependencies on the public open source project.

Has that since changed?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You remember correctly. I talked with Jerry and was told there's a public version available but I am struggling to find it.
And I can't get this CL to compile yet.
@mrjerryjohns FYI.

import public "storage/datapol/annotations/proto/retention_annotations.proto";
import public "wdl/data_access.proto";
import public "wdl/vendors.proto";
import "weave/common/units.proto";
Expand Down Expand Up @@ -246,6 +248,14 @@ message WdlPropertyOptions {
optional bool ephemeral = 51; // Ephemeral properties allow publishers to 'forget' the value of a property and depend on other caching re-publishers of this information
// in the system to retain its previous value. This should be used sparingly (see specification).
// Ephemeral properties are always nullable, so use nullability in conjunction with this.


// Advises downstream services on whether a field can be stored in a secondary
// storage or not. By default no fields should be stored (RT_OBSOLETE is the
// minimum retention applicable).
// Retention tags indicate the minimum desired retention for a field in a
// proto buffer.
optional datapol.RetentionTag retention = 52 [default = RT_OBSOLETE];
}

/**
Expand Down