Split out common functionality and implement device specific module #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With splitting out common module functionality we're now able to add different implementations for the charger module. For target emulator machines this is still the same dummy implementation as before. Open-webOS-DCO-1.0-Signed-off-by: Simon Busch <[email protected]>
The device implementation is based on the common linux power supply interface and is per default enabled to detect changes for AC and USB chargers. It's using libudev to detect a changed charger status. Open-webOS-DCO-1.0-Signed-off-by: Simon Busch <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mainly implements a device specific charger module. Its mainly the same implementation as I did for the battery module in the other pull-request. Before you can merge this you have to merge the battery changes to get the required libudev package detection into the cmake build definition.
Please tell me if you have any questions about the implementation.
regards,
Simon